From owner-svn-src-all@FreeBSD.ORG Sun Feb 23 22:56:12 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 986785FA; Sun, 23 Feb 2014 22:56:12 +0000 (UTC) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4BB111E3B; Sun, 23 Feb 2014 22:56:12 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 6C44A25D38A5; Sun, 23 Feb 2014 22:56:10 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 94583C22B93; Sun, 23 Feb 2014 22:56:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id ARPQKx8FO4td; Sun, 23 Feb 2014 22:56:07 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:f0bf:19b6:d9c0:f42b] (unknown [IPv6:fde9:577b:c1a9:4410:f0bf:19b6:d9c0:f42b]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 67FEEC22BD0; Sun, 23 Feb 2014 22:56:06 +0000 (UTC) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r262351 - head/sys/netinet6 From: "Bjoern A. Zeeb" In-Reply-To: <201402230127.s1N1RMoX052542@svn.freebsd.org> Date: Sun, 23 Feb 2014 22:56:02 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201402230127.s1N1RMoX052542@svn.freebsd.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.1827) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2014 22:56:12 -0000 On 23 Feb 2014, at 01:27 , Craig Rodrigues wrote: > Author: rodrigc > Date: Sun Feb 23 01:27:22 2014 > New Revision: 262351 > URL: http://svnweb.freebsd.org/changeset/base/262351 >=20 > Log: > Remove KASSERT from in6p_lookup_mcast_ifp(). >=20 > When the devel/jenkins port, version 1.551 was started, > the kernel would panic if INVARIANTS was enabled in the kernel = config. >=20 > Suggested by: bms This reads to me =93we hit the assert, bms suggested to remove it=94. = Great! Caught a bug! Where is it? In no way the commit message tells = me why? Why did we not hit the assert in the last n years? What has = changed that we hit it now? Was the assert wrong from the beginning? = Did we hit a real bug elsewhere and now lost the tracking for it? Could you please at least for the archives explain? >=20 > Modified: > head/sys/netinet6/in6_mcast.c >=20 > Modified: head/sys/netinet6/in6_mcast.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/netinet6/in6_mcast.c Sun Feb 23 00:46:05 2014 = (r262350) > +++ head/sys/netinet6/in6_mcast.c Sun Feb 23 01:27:22 2014 = (r262351) > @@ -1781,8 +1781,6 @@ in6p_lookup_mcast_ifp(const struct inpcb > ("%s: not INP_IPV6 inpcb", __func__)); > KASSERT(gsin6->sin6_family =3D=3D AF_INET6, > ("%s: not AF_INET6 group", __func__)); > - KASSERT(IN6_IS_ADDR_MULTICAST(&gsin6->sin6_addr), > - ("%s: not multicast", __func__)); >=20 > ifp =3D NULL; > memset(&ro6, 0, sizeof(struct route_in6)); =97=20 Bjoern A. Zeeb ????????? ??? ??????? ??????: '??? ??? ???? ?????? ??????? ?? ?? ??????? ??????? ??? ????? ????? ???? ?????? ?? ????? ????', ????????? ?????????, "??? ????? ?? ?????", ?.???