From owner-freebsd-stable@FreeBSD.ORG Wed May 14 06:37:54 2008 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 663311065678 for ; Wed, 14 May 2008 06:37:54 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.bluestop.org (unknown [IPv6:2001:41c8:1:548a::2]) by mx1.freebsd.org (Postfix) with ESMTP id 0B3158FC2A for ; Wed, 14 May 2008 06:37:54 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from tau.draftnet (unknown [IPv6:2a01:348:10f:0:219:b9ff:fe54:f04a]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by muon.bluestop.org (Postfix) with ESMTP id 61DD9301B5; Wed, 14 May 2008 07:37:52 +0100 (BST) Message-ID: <482A88A5.4060108@cran.org.uk> Date: Wed, 14 May 2008 07:37:25 +0100 From: Bruce Cran User-Agent: Thunderbird 2.0.0.14 (X11/20080505) MIME-Version: 1.0 To: Ian Smith References: In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: stable@freebsd.org, "Alexandre \"Sunny\" Kovalenko" , jonathan@kc8onw.net Subject: Re: ATA APM and NCQ support in FreeBSD atacontrol X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2008 06:37:54 -0000 Ian Smith wrote: > I take Jonathan's point that it would be nice to have this functionality > in atacontrol, though perhaps the BUGS section in ataidle(8) precludes > merging that? cc'ing Bruce Cran in case he wants to add something .. ataidle is at the moment quite dumb about sending commands: it doesn't check that the drive actually supports APM/AAM before sending the commands, and that's an easy check to do. If this was being added to atacontrol I think I'd want to do quite a bit of work first to make it more robust. However I don't think the code from ataidle could ever just be merged in to atacontrol because the code styles are quite different; however since the interface to the ATA driver is quite straightforward it should be trivial to re-implement or copy the bits needed. -- Bruce