From owner-svn-ports-all@freebsd.org Fri Sep 14 15:12:55 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6EE9108B972; Fri, 14 Sep 2018 15:12:55 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C8B985D09; Fri, 14 Sep 2018 15:12:55 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: by mail-ua1-f51.google.com with SMTP id 101-v6so7186681uav.7; Fri, 14 Sep 2018 08:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uELNp55x5CCroHfiHH6kGWkkwvpa6AYRh9Jki3IW6Fk=; b=EqIkIHXJiEoMTpM/B5hvnGyFLzjUdx+hJhavRpv/Xl4f97E2AWdJ042hpPnXD+L2LH /VeN1T/yRAPudZwnkENREbA6O2fyu56H5GUyfoZEBWjHWhvqNw+jY8Qd2mHNPEBeZPIu hEQBbOGIJTDz9SyWLU8Mq6cmlSHtBEqTYwCYKpAboVJZXAS/Vdpm5OBTJeGQh12A+mD6 lZNfsOKBlgkvwusx58IF1D6N8ZOuHWn7AOZOJlW/LfAGwXhFhWUYT2pHBfg+213fnfM2 s2UTJSNjm01tfEZ4jB1G5AkXpDFx7D+rHZLgBJ+OGQ7QJ/cYmCWh0ulNgkLnBWY+ELjV xVnQ== X-Gm-Message-State: APzg51CCKXkBhV+dQKiwtbjx7XQkaW3myeLIlHM2pNlG9X2dXcc+031J YixNpaOq9alvyQzd990JXbntWW/Gmb/Vaw6b0HICetuwH5g= X-Google-Smtp-Source: ANB0VdY4Lt9dw60A+8qAy0ByqS2UUAcLpP6j5SnpcuUAs1P4+WBFSNEkJYmtQBMSbAUtTm17plVFc9IY/XgAoN8MSoQ= X-Received: by 2002:ab0:1950:: with SMTP id u16-v6mr4052437uag.179.1536937968584; Fri, 14 Sep 2018 08:12:48 -0700 (PDT) MIME-Version: 1.0 References: <201809140758.w8E7w5D9093846@repo.freebsd.org> <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc> In-Reply-To: <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc> From: "Jason E. Hale" Date: Fri, 14 Sep 2018 11:12:37 -0400 Message-ID: Subject: Re: svn commit: r479762 - head/science/cp2k To: Mathieu Arnold Cc: Yuri Victorovich , ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, jbeich@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 15:12:56 -0000 On Fri, Sep 14, 2018 at 6:26 AM Mathieu Arnold wrote: > > On Fri, Sep 14, 2018 at 07:58:05AM +0000, Yuri Victorovich wrote: > > +.include > > + > > +.if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI} > > +pre-configure: > > + @if [ ! -e ${LOCALBASE}/lib/libfftw3_omp.so ] ; then \ > > + ${ECHO_MSG} "The OPENMP and OPENMP_MPI options require math/fftw3" ; \ > > + ${ECHO_MSG} "to be built and installed with the OPENMP option ON" ; \ > > + exit 1; \ > > + fi > > +.endif > > I keep wondering why you always try so hard to invent new ways of doing > things. > > .if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI} > . if !exists(${LOCALBASE}/lib/libfftw3_omp.so) > BROKEN= The OPENMP and OPENMP_MPI options require math/fftw3 to be built and installed with the OPENMP option ON > . endif > .endif > Don't blame him, mat. The suggestion was mine. I actually got the idea from antoine@: https://svnweb.freebsd.org/ports?view=revision&revision=406268. If BROKEN is set, unless the user knows or wants to pass the -T flag to poudriere, it will not attempt the build in bulk mode even if the user has the correct options for fftw3 set. Your condition is always true in a clean environment. - Jason