From owner-cvs-usrsbin Mon Nov 10 04:28:54 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id EAA28005 for cvs-usrsbin-outgoing; Mon, 10 Nov 1997 04:28:54 -0800 (PST) (envelope-from owner-cvs-usrsbin) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id EAA27987; Mon, 10 Nov 1997 04:28:45 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id MAA28130; Mon, 10 Nov 1997 12:28:43 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.6/8.8.6) id NAA17807; Mon, 10 Nov 1997 13:28:43 +0100 (MET) Date: Mon, 10 Nov 1997 13:28:43 +0100 (MET) Message-Id: <199711101228.NAA17807@bitbox.follo.net> From: Eivind Eklund To: Brian Somers CC: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG In-reply-to: Brian Somers's message of Fri, 7 Nov 1997 16:28:12 -0800 (PST) Subject: Re: cvs commit: src/usr.sbin/ppp ccp.c command.c ipcp.c lcp.c lcp.h main.c modem.c modem.h os.c route.c References: <199711080028.QAA27831@freefall.freebsd.org> Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > brian 1997/11/07 16:28:12 PST > > Modified files: > usr.sbin/ppp ccp.c command.c ipcp.c lcp.c lcp.h main.c > modem.c modem.h os.c route.c > Log: > Don't pass global vars as args. I don't think patching away that is a good idea. The goal should be to make the global variables static/local; this kind of passing should be introduced more places, not removed. Then you can make the global variable static/dynamic somewhere later. IMNSHO, Eivind.