From owner-freebsd-alpha Thu Jun 7 14:26:50 2001 Delivered-To: freebsd-alpha@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 2282E37B403 for ; Thu, 7 Jun 2001 14:26:48 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.3/8.11.2) with ESMTP id f57LOY137425; Thu, 7 Jun 2001 14:24:34 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <15135.58046.974661.129491@grasshopper.cs.duke.edu> Date: Thu, 07 Jun 2001 14:24:39 -0700 (PDT) From: John Baldwin To: Andrew Gallatin Subject: RE: CFR: db_trace.c from NetBSD Cc: mjacob@feral.com, dfr@nlsystems.com, freebsd-alpha@FreeBSD.org Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 07-Jun-01 Andrew Gallatin wrote: > > I'd like to update our db_trace.c to use Ross Harvey's clever > NetBSD traceback methods. > > The advantages are that we get a _lot_ more info. Yes please. The only comments I would make is that I would not remove the check that bounds the count at 65535 for the default case (so that if you hit a loop it will terminate at 65535 frames not 2 billion frames). Once this is committed I will probably change the way the have_addr branch works to be identical to that on the x86 (just trace pid, not trace tpid). This looks great. Thanks! -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message