From owner-svn-src-all@FreeBSD.ORG Mon Jul 30 23:00:10 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 602291065673; Mon, 30 Jul 2012 23:00:09 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8CAB78FC08; Mon, 30 Jul 2012 23:00:08 +0000 (UTC) Received: by vbmv11 with SMTP id v11so6309275vbm.13 for ; Mon, 30 Jul 2012 16:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=B81uIMuv6V/+ZPnBx00craoUzWstqjtvtkDtpkv4wg8=; b=A0EqT9DcEI5mE9xJENATwEnnvubPAm+K4x9fEAlONSPURPF0sYQDH+xD7Fip66Rkqc d3KbQR6198LZ++mx8nyoO1uf+1qQ85feqLNaTBLQquhLT6hgb4q/5ukNYWVlsT1DC1ef VtfPPtliJ/sS1dpmeu2AjG9ErhOtDKSnZ5FX/5PkKnDXX/jWztH+MGCyfFsEhEQ2N738 UsRH4l5CPm18aTcb8u+2JSm3Wn3v4NI/eyznTB6H5in2n9WyQYmwuRp+uYsDVJx8TpgC xEUJkB4YtY1BxHBhRlDs0RVaPYcu6N4t2AyHw0gzwsV41nBjKMN//2x9hPGRx6lGkUzT d16A== MIME-Version: 1.0 Received: by 10.58.189.69 with SMTP id gg5mr750943vec.6.1343689207777; Mon, 30 Jul 2012 16:00:07 -0700 (PDT) Received: by 10.58.187.225 with HTTP; Mon, 30 Jul 2012 16:00:07 -0700 (PDT) In-Reply-To: <201207301445.45210.jhb@freebsd.org> References: <201207251128.q6PBSFlt052575@svn.freebsd.org> <201207301445.45210.jhb@freebsd.org> Date: Mon, 30 Jul 2012 16:00:07 -0700 Message-ID: From: Jack Vogel To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, Luigi Rizzo , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r238765 - head/sys/dev/e1000 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2012 23:00:10 -0000 I have some changes that are needed anyway, I will change this to a tuneable. Jack On Mon, Jul 30, 2012 at 11:45 AM, John Baldwin wrote: > On Wednesday, July 25, 2012 7:28:15 am Luigi Rizzo wrote: > > Author: luigi > > Date: Wed Jul 25 11:28:15 2012 > > New Revision: 238765 > > URL: http://svn.freebsd.org/changeset/base/238765 > > > > Log: > > Use legacy interrupts as a default. This gives up to 10% speedup > > when used in qemu (and this driver is for non-PCIe cards, > > so probably its largest use is in virtualized environments). > > > > Approved by: Jack Vogel > > MFC after: 3 days > > Why not make this a tunable or some such? You could even have it only use > the > legacy handler under qemu easily enough. There's no reason this has to be > a > compile-time option. This is almost certainly slower on real hardware > where > this is important to work around dubious Intel Host-PCI bridges that > result in > aliased USB interrupts for every em(4) interrupt. > > -- > John Baldwin >