Date: Sat, 22 Dec 2018 07:16:06 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Tobias Kortkamp <tobik@freebsd.org>, Yuri Victorovich <yuri@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r487866 - head/sysutils/xorriso Message-ID: <20181222061606.qcieumunsnrclujc@atuin.in.mat.cc> In-Reply-To: <alpine.LSU.2.21.1812211322180.3662@anthias.pfeifer.com> References: <201812200852.wBK8qZm1076469@repo.freebsd.org> <20181220094013.GA24592@frea.tobik.me> <alpine.LSU.2.21.1812211322180.3662@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--2tvr5c3ihvlbatki
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Dec 21, 2018 at 06:16:11PM -1000, Gerald Pfeifer wrote:
> On Thu, 20 Dec 2018, Tobias Kortkamp wrote:
> >> Author: yuri
> >> Date: Thu Dec 20 08:52:35 2018
> >> New Revision: 487866
> > This isn't right. A new file is installed, so a PORTREVISION bump
> > is required. It should be added as INFO (or TK_INFO since it appears
> > to be optional similar to xorriso-tcltk.1.gz) to the port if it's
> > really needed so that indexinfo is called after install.
> >=20
> > The port already has that and also has do-install-TK-off which
> > deletes it from STAGEDIR but the info path was not adjusted in
> > r484628 when ${PREFIX}/info was moved to ${PREFIX}/share/info.
>=20
> I see that Yuri applied a follow-up patch based on your feedback,
> but would do you think about the following?
>=20
> From Mk/bsd.ports.mk:
>=20
> # INFO_PATH - Path, where all .info files will be installed by your
> # port, relative to ${PREFIX}
>=20
> And:
>=20
> INFO_PATH?=3D share/info
>=20
>=20
> Okay to apply the little patch below?
>=20
> Gerald
>=20
> Index: sysutils/xorriso/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sysutils/xorriso/Makefile (revision 488030)
> +++ sysutils/xorriso/Makefile (working copy)
> @@ -51,7 +51,7 @@
> do-install-TK-off:
> ${RM} ${STAGEDIR}${PREFIX}/bin/xorriso-tcltk \
> ${STAGEDIR}${PREFIX}/man/man1/xorriso-tcltk.1.gz \
> - ${STAGEDIR}${PREFIX}/share/info/xorriso-tcltk.info
> + ${STAGEDIR}${PREFIX}/${INFO_PATH}/xorriso-tcltk.info
Only if the patch actually respects INFO_PATH and it does not breka if the =
path changes.
--=20
Mathieu Arnold
--2tvr5c3ihvlbatki
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlwd1qZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkjEIw//S4qfRXQ3FqeP95JQXN7fAE6LWBUrPq8R1bhLU0nuNtG3H4jUWcrkhNhR
9DwOEcJsJ+6R9S+OtWNG/OnEyyC8/2C0wNPYyz9FNyUesAIA+UnKVcBSDPTBARQo
M5wqadLWJWdgDmft7OloXfqrOefAecp0jnHtYYtjS97LTodHOG6+nbEA4Kh3DkES
xwIKBDvgdw1By66ZX0u5tFn/G+Q0KXq8ffmey7CDna+hV5H0TGuRYRujLgBOxLvl
QASMcPK/JcoDDXJ8yhHbf7EZJyZJG4INMp6a589G9kxbFItLJA5WY2/tKtKpp7t6
4+LELFIcfXTybQ92soxp/sgZsIxHZj9qoKyhnWzytGIx0nveSFmYQnUVbsHr/hPy
7puQNPmdjKS6h8pg8r6YJC+kGKBsanrQy7d7D2RuccPM0DxxegCxob6H19XDbGBf
LiJvjeXo/7A/oLHVawUelV6qymlF1Ud4UgNFzbDOn/s6Q9vOxFboUoYjoaWtGOPs
SZ65MTyxS1hCePkWnNLcbu/ZQzx83duUm7IHABv20pfAwQdpigFpTZ7S0GQsubw8
Gbipxb40Igjwy0kMctoqvGQ9LOjzgDBkga03rdwORMi/FY3rA74g40R91UL7Os9l
qRjBGwg5DFtceKOXUA1SpJlG844SlW/o+FbAk8Ng/HeBvnJmBVk=
=DmOg
-----END PGP SIGNATURE-----
--2tvr5c3ihvlbatki--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181222061606.qcieumunsnrclujc>