From owner-svn-src-head@FreeBSD.ORG Tue Aug 31 06:24:35 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 832921065694; Tue, 31 Aug 2010 06:24:35 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 2D00F8FC15; Tue, 31 Aug 2010 06:24:34 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 8D0A945EE5; Tue, 31 Aug 2010 08:24:33 +0200 (CEST) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 853C745B36; Tue, 31 Aug 2010 08:24:28 +0200 (CEST) Date: Tue, 31 Aug 2010 08:24:19 +0200 From: Pawel Jakub Dawidek To: David Xu Message-ID: <20100831062419.GK1871@garage.freebsd.pl> References: <201008300006.o7U065Nu078151@svn.freebsd.org> <4C7CD808.3060903@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RNRUMt0ZF5Yaq/Aq" Content-Disposition: inline In-Reply-To: <4C7CD808.3060903@freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211982 - head/sbin/hastd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2010 06:24:35 -0000 --RNRUMt0ZF5Yaq/Aq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2010 at 10:23:04AM +0000, David Xu wrote: > Pawel Jakub Dawidek wrote: > >Author: pjd > >Date: Mon Aug 30 00:06:05 2010 > >New Revision: 211982 > >URL: http://svn.freebsd.org/changeset/base/211982 > > > >Log: > > Use sigtimedwait(2) for signals handling in primary process. > > This fixes various races and eliminates use of pthread* API in signal= =20 > > handler. > > =20 > > Pointed out by: kib > > With help from: jilles > > MFC after: 2 weeks > > Obtained from: Wheel Systems Sp. z o.o. http://www.wheelsystems.com > > > >Modified: > > head/sbin/hastd/primary.c > > > Note that if you are sigwaiting signals, these signals should be masked, > otherwise, there is a race condition. I have not read the code, maybe > this is not a problem. I do that, yes. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --RNRUMt0ZF5Yaq/Aq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkx8oBMACgkQForvXbEpPzS1/gCg6dqLqInRQu1WkpwQ3K2Isldl uroAmgKX5gTmUKhsE09g6kjSihSOZwxg =8k36 -----END PGP SIGNATURE----- --RNRUMt0ZF5Yaq/Aq--