From owner-svn-ports-head@FreeBSD.ORG Thu Feb 20 08:45:26 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7880767D; Thu, 20 Feb 2014 08:45:26 +0000 (UTC) Received: from mail-wg0-x236.google.com (mail-wg0-x236.google.com [IPv6:2a00:1450:400c:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5D0EA1441; Thu, 20 Feb 2014 08:45:25 +0000 (UTC) Received: by mail-wg0-f54.google.com with SMTP id l18so1189227wgh.33 for ; Thu, 20 Feb 2014 00:45:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=RNigp0XBya9FiYHf8yHXiVIubECDtYJG+b1xfRynbSI=; b=OMtzORYdik8OELpElOreJPOBkjW2csd77mQhtfOfpomPOOWwYQgHcfBlN+03dXbsOU ldX520TocfDvqFU1izic2uygnYPeuhzdKhcwiTkDusRHyOY6NSFML4hz0IqVfwk3rRDa Jzwe2NPVwTHGpB8zUaGIj+j8hDWDpu6blhJoh5Z+dneu+FydWfDfEAzl6Tw6G8hTXVNk Aq9YFga3mfzSrGTVpVXzvziOIJrMY1gCPZ6StPgGZm+/VYTu8GzwCX4AmD3fsQ5pBC8X 0HBixvRPAL0igUfmr3GwWKnGlgBSxrv/I1chvZ5eI40EoTI/FkwWvyWCjjxY5MM43rKE 8dIA== X-Received: by 10.180.73.19 with SMTP id h19mr1261406wiv.40.1392885923520; Thu, 20 Feb 2014 00:45:23 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id ga20sm59562639wic.0.2014.02.20.00.45.21 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 20 Feb 2014 00:45:21 -0800 (PST) Sender: Baptiste Daroussin Date: Thu, 20 Feb 2014 09:45:19 +0100 From: Baptiste Daroussin To: Ruslan Makhmatkhanov Subject: Re: svn commit: r345165 - head/devel/hgsvn Message-ID: <20140220084519.GB1699@ithaqua.etoilebsd.net> References: <201402192351.s1JNplot033193@svn.freebsd.org> <20140219235746.GA1699@ithaqua.etoilebsd.net> <5305BF40.90003@yandex.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline In-Reply-To: <5305BF40.90003@yandex.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Alex Kozlov , Xin LI , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Feb 2014 08:45:26 -0000 --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 20, 2014 at 12:39:28PM +0400, Ruslan Makhmatkhanov wrote: > Baptiste Daroussin wrote on 20.02.2014 03:57: >=20 > [...] >=20 > >> USE_PYTHON=3D yes > >> USE_PYDISTUTILS=3Dyes > >> +USE_ZIP=3D yes > >> PYDISTUTILS_AUTOPLIST=3D yes > >> PLIST_SUB=3D VERSION=3D${PORTVERSION} PYVER=3D${PYTHON_VERSION:S/pyt= hon//} > > > > Why readding USE_ZIP? while bsdtar can just extract it fine? >=20 > Bapt, I already asked this, but got no response. ak@ made a patch to=20 > make USE_ZIP conditionally depend on unzip on a systems with old bsdtar.= =20 > But it was never committed and pending portmgr@ approval. What the=20 > reason of this? What makes .zip so special, that we can't use this nice= =20 > knob for it, but rather forced to construct pure ugliness with EXTRACT_SU= FX? >=20 > Thank you. >=20 > PS. mat@ argued that it fails to deal with some of the zip-archives out= =20 > there, but ak@ then said that he had no problems with any .zip's since=20 > libarchive 3.0.4. >=20 kientzle@ told me that there are still some infozip are not supported. Plus our unzip command it not compatible 100% with info zip one, thus slowly removing the bsdtar, I'm all open for a better solution that USE_ZIP (which= I personnaly find as ugly as EXTRACT_SUFX :) Any proposition would be great, note that having this not relying unzip(1) = but using bsdtar(1) is better to support older freebsd without libarchive 3.0.4 regards, Bapt --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlMFwJ8ACgkQ8kTtMUmk6Ez3KQCffe1OQoAd4arjF89Klcz8Oyzn ynQAn2E+D0RX9TWF1XVZhZQucvchUVxJ =NviQ -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE--