Date: Sun, 6 May 2018 17:10:22 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Kurt Jaeger <pi@FreeBSD.org>, Koichiro Iwao <meta@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506151022.63wom7xgw6doi4dk@ivaldir.net> In-Reply-To: <20180506105012.GA39087@FreeBSD.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <20180506103420.GW25490@fc.opsec.eu> <20180506105012.GA39087@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--z2austp6pziy42oj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 06, 2018 at 10:50:12AM +0000, Alexey Dokuchaev wrote: > On Sun, May 06, 2018 at 12:34:20PM +0200, Kurt Jaeger wrote: > > > On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote: > > > > New Revision: 469188 > > > > URL: https://svnweb.freebsd.org/changeset/ports/469188 > > > >=20 > > > > Log: > > > > ports-mgmt/pkg_replace: Update to 20180424 > > > > =20 > > > > - Cleanup code > > > > - Speed up and strictly check package's dependencies > > > > - While here, pet portlint by using pkg-plist instead of PLIST_FI= LES > > >=20 > > > Could you explain what did you achieve by moving three-line PLIST_FIL= ES > > > into pkg-plist? How can "pet portlint" be a reason for a change while > > > we generally encourage converting <6-line pkg-plist's into PLIST_FILE= S? > >=20 > > There was a problem if the pkg-list stayed in PLIST_FILES > > (the build in poudriere failed with a signal 6 in make package). > >=20 > > Koichiro is working to reproduce/report this, until then... >=20 > *facepalm*. This poudriere-driven development is more and more disturbin= g. > You didn't attempt to understand the problem, you didn't attempt to fix t= he > PLIST_FILES (remove bogus %%ETCDIR%% since this is Makefile), you didn't > ask for a peer review. meta@ pessimized the port, provided wrong commit > log (it tells *nothing* about poudriere failing with a signal 6 in make > package, it says "pet portlint"), and you've approved it like there's > nothing wrong with all of this. :-( If you read it carefully this is not a "poudriere-driven development". as it shows a real bug happening to anyone running make package... And most of the poudriere-driven development as you call them which are disturbing are in fact real bugs in the ports, and nothing poudriere only. The only things that may annoy you are bugs in the ports that are appearing= only when not in a clean environment (so no reproducible in poudriere) which is= no t the case here. Bapt --z2austp6pziy42oj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlrvGt4ACgkQY4mL3PG3 Plq3hA//cVGdizSA39xSreBaE0lfK4E6hB3hckbgEJxNdeTW2HTPUWxxoKxFa997 tIFbMJbYSdiRpxOk2yhq9kl/DgIqOL82RTehDUPvEscIV1+ogZt1YA0SRcuuX9// 6Gg6JnhExa4LbQAkw5WFprmoFad4vJryT1oesWvVFr9FXJyzVjd9+CY+qMcCDf0n LzFSVbTfg1kXHKaohBUEQdZy3CCXoENF5dV0XUUj+ivpPXeYb9KzyAowmNFZepSr cRH/6qnCEP/RUEOiGZp3G3uZ5p7qNFDk6Ep1TiKvfW7+PKbI4s8UephiWUiw6Etb sLKtWGc+xk/QK9PnpJfOb73kgJkvRdaMNk515VfFB+jQx1YAIrlx8qo4K/DjXgiU 1mC2oh0U1Lb9DF0iA+Tj3jvP+x2VkaY9W5+4FAn2sJCSEfXrycsrCnioOpyRt6oO sxVxb7Nc+qriTKIfi/MDxbkaAurFFxqwjOuzff5oAGOKaFaXDScE3T3Tqpp4z3Rq qwpOZDsWpUHDhxe88r8r28FKukCshmE28opmwsWYaiU6b4i/LL1tbFfBVKPND89i nb/mjqtDE39oshZiGIKkCMEdnYEbtobrlPANmvDJ57H3eK6r3glkhfdE6F+EWrZX gIFmwhJGi8PPQ8Wb5+ps3EMj3i/VBrPuoL9VaMeMp2n2PXcMyt8= =KiKT -----END PGP SIGNATURE----- --z2austp6pziy42oj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506151022.63wom7xgw6doi4dk>