From owner-freebsd-ports@FreeBSD.ORG Wed Jan 16 07:35:39 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E838A16A421 for ; Wed, 16 Jan 2008 07:35:39 +0000 (UTC) (envelope-from jrhett@svcolo.com) Received: from kininvie.sv.svcolo.com (kininvie.sv.svcolo.com [64.13.135.12]) by mx1.freebsd.org (Postfix) with ESMTP id C624213C465 for ; Wed, 16 Jan 2008 07:35:39 +0000 (UTC) (envelope-from jrhett@svcolo.com) Received: from [172.16.12.9] (covad-jrhett.meer.net [209.157.140.144]) (authenticated bits=0) by kininvie.sv.svcolo.com (8.14.1/8.14.1) with ESMTP id m0G7ZJla005808; Tue, 15 Jan 2008 23:35:21 -0800 (PST) (envelope-from jrhett@svcolo.com) Message-ID: <478DB3C0.6000605@svcolo.com> Date: Tue, 15 Jan 2008 23:35:28 -0800 From: Jo Rhett Organization: Silicon Valley Colocation User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: d@delphij.net References: <790a9fff0801051224p4fb8481pbcc24051b2438dcf@mail.gmail.com> <4782EC51.6020108@delphij.net> In-Reply-To: <4782EC51.6020108@delphij.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: undef - jrhett@svcolo.com is whitelisted. X-CanItPRO-Stream: default X-Canit-Stats-ID: 216908 - facfab6c916d X-Scanned-By: CanIt (www . roaringpenguin . com) on 64.13.135.12 Cc: ports@freebsd.org, Xin LI , Scot Hetzel , sergei@freebsd.org Subject: Re: sysutils/cfengine: invalid use of USE_BDB X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2008 07:35:40 -0000 This makes sense. The current code FYI does require 4.4 or higher, so 44+ is accurate. Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Scot Hetzel wrote: >> I have noticed that sysutils/cfengine is using USE_BDB incorrectly. >> >> USE_BDB?= 46 >> >> The USE_BDB variable is not a user setable variable. If someone were >> to read this Makefile, they would get the wrong impression that they >> should set USE_BDB in there /etc/make.conf, ports.conf, or >> portupgrade.conf file. When they should instead be setting the >> WITH_BDB_VER variable. >> >> The USE_BDB should be set to the minimum version of Berkeley DB that >> the port will build with. >> >> USE_BDB= 44+ >> >> And left up to the person installing the port to specify a higher version. >> >> If you want to take the choice away from the installer and have the >> port always use BDB 4.6, then the port should use: >> >> USE_BDB= 46 >> >> Which will prevent the use of BDB 4.4 and 4.5 from ever being used by this port. > > I think the proper use of *_BDB variables is that: > > WITH_BDB?= 46 > > (An advisory usage), and > > USE_BDB= yes > > as in the attachment. > > Cheers, > - -- > Xin LI http://www.delphij.net/ > FreeBSD - The Power to Serve! > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.4 (FreeBSD) > > iD8DBQFHguxRi+vbBBjt66ARAuHIAKC5rRxKOvsAveDPEoAXbQvKxa4giACfQEpO > EJk7hRJusCc6sWaTpLfiCoM= > =yUim > -----END PGP SIGNATURE----- > > > ------------------------------------------------------------------------ > > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" -- Jo Rhett senior geek Silicon Valley Colocation