From owner-freebsd-bugs Tue Oct 23 22:48:34 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from smtp-1.enteract.com (smtp-1.enteract.com [207.229.143.33]) by hub.freebsd.org (Postfix) with ESMTP id 7D5D737B406 for ; Tue, 23 Oct 2001 22:48:29 -0700 (PDT) Received: from bjorn.goddamnbastard.org (bjorn.goddamnbastard.org [216.80.6.225]) by smtp-1.enteract.com (Postfix) with SMTP id A1B276F4D for ; Wed, 24 Oct 2001 00:48:26 -0500 (CDT) Received: (qmail 3832 invoked by uid 1000); 24 Oct 2001 05:48:25 -0000 Date: Wed, 24 Oct 2001 00:48:25 -0500 From: ryan beasley To: gnats-admin@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/31457: OpenSSH 2.9 login(1) support broken Message-ID: <20011024004825.A509@bjorn.goddamnbastard.org> References: <20011023182104.23219.qmail@bjorn.goddamnbastard.org> <200110231830.f9NIU0c57379@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: <200110231830.f9NIU0c57379@freefall.freebsd.org>; from gnats-admin@FreeBSD.org on Tue, Oct 23, 2001 at 11:30:00AM -0700 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 23, 2001 at 11:30:00AM -0700, gnats-admin@FreeBSD.org wrote: > Thank you very much for your problem report. > It has the internal identification `bin/31457'. > The individual assigned to look at your > report is: freebsd-bugs.=20 You just gotta love pointer initialization. After poking around for a bit, I modified session.c to take care of proper declaration of **env. This will now call the initialization code at session.c:1128. :) --- src/crypto/openssh/session.c.orig Wed Oct 24 00:35:57 2001 +++ src/crypto/openssh/session.c Wed Oct 24 00:36:26 2001 @@ -1003,7 +1003,7 @@ char cmd[1024]; FILE *f =3D NULL; u_int envsize, i; - char **env; + char **env =3D NULL; extern char **environ; struct stat st; char *argv[10]; --=20 ryan beasley professional fat bastard http://www.goddamnbastard.org GPG Key ID 0x36321D13 with fingerprint 2074 CEB8 68AD 351A 85E6 98EB 09BA 36D9 3632 1D13 --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE71lYpCbo22TYyHRMRAn6CAJ4qkR/5poJoopA/x1i/gFubNPUmJQCcDhwS NWzSwFLWtqAyPpusxZYlVKg= =R0nP -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message