From owner-freebsd-current@FreeBSD.ORG Tue Feb 7 18:51:55 2006 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E78BE16A420 for ; Tue, 7 Feb 2006 18:51:55 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52DEE43D45 for ; Tue, 7 Feb 2006 18:51:55 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from [194.192.25.142] (spider.deepcore.dk [194.192.25.142]) by spider.deepcore.dk (8.13.4/8.13.4) with ESMTP id k17IpoUi005884; Tue, 7 Feb 2006 19:51:53 +0100 (CET) (envelope-from sos@FreeBSD.org) Message-ID: <43E8EC46.1040104@FreeBSD.org> Date: Tue, 07 Feb 2006 19:51:50 +0100 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Thunderbird 1.5 (X11/20060130) MIME-Version: 1.0 To: Garry Belka References: <43E7E011.6000301@networkphysics.com> In-Reply-To: <43E7E011.6000301@networkphysics.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-mail-scanned: by DeepCore Virus & Spam killer v1.16 Cc: freebsd-current@FreeBSD.org Subject: Re: [ATA] [patch] crashes, deadlock, memory leaks, . plus LSI RAID write support X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2006 18:51:56 -0000 Garry Belka wrote: > I had to fix some ATA bugs to increase its robustness. > > See a problem report and a patch at > http://www.freebsd.org/cgi/query-pr.cgi?pr=92786 > > The patch enables a support for disk failures and enables hot-swapping > SATA disks without a frequent system crash. > It deals with a deadlock in an ata-raid design that causes systems > to hang often on reboot, after RAID rebuild or in other situations. > The patch implements additional locking to access RAID labels. > The patch implements partial reference counters > for ATA requests to avoid memory leaks or twice-freed requests > and crashes. > > The patch includes support for writing RAID labels on LSIv3. This is > the builtin SATA RAID on the current Intel Server Board (SE7520JR2). > > More details are given in the problem report linked above. > > In particular, the patch proposes an easy scheme for ATA RAID label > construction that if accepted will enabe to add GEOM layer > based on ATA RAID native labels at a later time, and reuse > label reading and filling up functions. This is not possible at present. > > The patch was stable in our test, and I'd be glad > to find out how well it works for you. I'll look into it, from a quick glance some of it does address issues that is on my TODO list already, so this could save me some of the time/trouble, however I need to coordinate with my WIP here so give me some time to sort this out. Thanks for looking into this ! -Søren