Date: Thu, 8 Jun 2006 16:35:22 GMT From: Kirk Strauser <kirk@daycos.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/98715: Added "WITH_SENDFILE" configuration knob to ftp/pure-ftpd port Message-ID: <200606081635.k58GZMQV020444@www.freebsd.org> Resent-Message-ID: <200606081840.k58IeF0G059229@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 98715
>Category: ports
>Synopsis: Added "WITH_SENDFILE" configuration knob to ftp/pure-ftpd port
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Jun 08 18:40:15 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Kirk Strauser
>Release: FreeBSD 6.1-STABLE i386
>Organization:
The Day Companies
>Environment:
FreeBSD web2.daycos.com 6.1-STABLE FreeBSD 6.1-STABLE #0: Sun May 21 11:50:41 CDT 2006 kirk@jail1.daycos.com:/usr/obj/usr/src/sys/JAIL1 i386
>Description:
Pure-FTPd uses the sendfile(2) syscall to transmit files by default. There
are currently some issues with sendfile and smbfs, with the end result that
users can't download files that reside on SMB mounts. Pure-FTPd includes
a "--without-sendfile" configuration option as a workaround, and this patch
adds convenient support for that option to the port.
>How-To-Repeat:
>Fix:
--- pure-ftpd.patch begins here ---
diff -urN pure-ftpd-old/Makefile pure-ftpd/Makefile
--- pure-ftpd-old/Makefile Wed May 17 05:16:05 2006
+++ pure-ftpd/Makefile Thu Jun 8 11:19:56 2006
@@ -47,7 +47,8 @@
THROTTLING "Bandwidth throttling" off \
BANNER "Show ${PORTNAME} welcome upon session start" on \
UPLOADSCRIPT "Support uploadscript daemon" off \
- UTF8 "Support for charset conversion (expreimental)" off
+ UTF8 "Support for charset conversion (expreimental)" off \
+ SENDFILE "Support for the sendfile syscall" on
.include <bsd.port.pre.mk>
@@ -113,6 +114,12 @@
.if defined(WITH_UTF8)
USE_ICONV= YES
CONFIGURE_ARGS+= --with-rfc2640
+.endif
+
+.if defined(WITH_SENDFILE)
+CONFIGURE_ARGS+= --with-sendfile
+.else
+CONFIGURE_ARGS+= --without-sendfile
.endif
.if ${OSVERSION} > 500000
--- pure-ftpd.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606081635.k58GZMQV020444>