From owner-svn-src-all@freebsd.org Mon Oct 10 16:01:25 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C53EAC0C6F0; Mon, 10 Oct 2016 16:01:25 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 404FEB24; Mon, 10 Oct 2016 16:01:25 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u9AG1EB5025167 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Mon, 10 Oct 2016 19:01:15 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u9AG1EB5025167 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u9AG1Enc025166; Mon, 10 Oct 2016 19:01:14 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 10 Oct 2016 19:01:14 +0300 From: Konstantin Belousov To: Ruslan Bukin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306964 - head/tests/sys/kern Message-ID: <20161010160114.GL68202@kib.kiev.ua> References: <201610101421.u9AELfwG012117@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201610101421.u9AELfwG012117@repo.freebsd.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 16:01:25 -0000 On Mon, Oct 10, 2016 at 02:21:41PM +0000, Ruslan Bukin wrote: > Author: br > Date: Mon Oct 10 14:21:40 2016 > New Revision: 306964 > URL: https://svnweb.freebsd.org/changeset/base/306964 > > Log: > Skip test on MIPS as we don't have shared page implemented yet. > > Sponsored by: DARPA, AFRL > Sponsored by: HEIF5 > > Modified: > head/tests/sys/kern/kern_copyin.c > > Modified: head/tests/sys/kern/kern_copyin.c > ============================================================================== > --- head/tests/sys/kern/kern_copyin.c Mon Oct 10 14:21:21 2016 (r306963) > +++ head/tests/sys/kern/kern_copyin.c Mon Oct 10 14:21:40 2016 (r306964) > @@ -59,6 +59,11 @@ ATF_TC_BODY(kern_copyin, tc) > { > char template[] = "copyin.XXXXXX"; > > +#ifdef __mips__ > + /* MIPS has no shared page implemented yet. */ > + atf_tc_skip("Platform is not supported."); > +#endif > + > scratch_file = mkstemp(template); > ATF_REQUIRE(scratch_file != -1); > unlink(template); Shared page does not have much to do with the test failure. The cause is that the UVA map on mips ends the highest mapped entry at the VM_MAXUSER_ADDRESS - PAGE_SIZE, while all other arches map either stack or shared page up to the VM_MAXUSER_ADDRESS. >From the comment in mips/include/vmparam.h it is not clear whether the test could be fixed by mapping a page at VM_MAXUSER_ADDRESS - PAGE_SIZE.