From owner-freebsd-ports-bugs@freebsd.org  Mon Sep  7 13:57:13 2015
Return-Path: <owner-freebsd-ports-bugs@freebsd.org>
Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DFF19CB5C9
 for <freebsd-ports-bugs@mailman.ysv.freebsd.org>;
 Mon,  7 Sep 2015 13:57:13 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 20AB1101A
 for <freebsd-ports-bugs@FreeBSD.org>; Mon,  7 Sep 2015 13:57:13 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t87DvCNg009342
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 7 Sep 2015 13:57:13 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 202949] bsd.options.mk: do-* target helpers fail to override
 default definitions
Date: Mon, 07 Sep 2015 13:57:13 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Ports Framework
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: jbeich@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: portmgr@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter cc
Message-ID: <bug-202949-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2015 13:57:13 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202949

            Bug ID: 202949
           Summary: bsd.options.mk: do-* target helpers fail to override
                    default definitions
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: jbeich@FreeBSD.org
                CC: freebsd-ports-bugs@FreeBSD.org

ports r394503 introduced do-* target option helpers. However, do-* targets are
special as defining them in Makefile overrides default definitions provided by
Mk/bsd.*.mk and Mk/Uses/*.mk. If a port only has helpers but not main do-*
target it'd lead to an undocumented behavior. So, NO_INSTALL can be used as a
workaround.

Here's an example:

  do-install:
  .if ${PORT_OPTIONS:MSDL}
      ${MKDIR} ${STAGEDIR}${DATADIR}
      ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME}
${STAGEDIR}${DATADIR}/${PORTNAME}
      ${LN} -sf ${DATADIR}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
  .else
      ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
  .endif

cannot be converted into

  do-install-SDL-on:
      ${MKDIR} ${STAGEDIR}${DATADIR}
      ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME}
${STAGEDIR}${DATADIR}/${PORTNAME}
      ${LN} -sf ${DATADIR}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin

  do-install-SDL-off:
      ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin

do-install in bsd.port.mk calls vendor install target which may not be defined
thus leading to an error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.