From owner-svn-src-head@freebsd.org Mon Jan 22 14:07:48 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FA94EC2CF2; Mon, 22 Jan 2018 14:07:48 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 26EF67D633; Mon, 22 Jan 2018 14:07:47 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.55.3]) by phk.freebsd.dk (Postfix) with ESMTP id 34B812739D; Mon, 22 Jan 2018 14:07:46 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id w0ME7UPM088260 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 22 Jan 2018 14:07:30 GMT (envelope-from phk@critter.freebsd.dk) Received: (from phk@localhost) by critter.freebsd.dk (8.15.2/8.15.2/Submit) id w0ME7UP8088259; Mon, 22 Jan 2018 14:07:30 GMT (envelope-from phk) To: Emmanuel Vadot cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules In-reply-to: <20180122145117.08173be547f5dd6fef296732@bidouilliste.com> From: "Poul-Henning Kamp" References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <20180122135905.203e19ce94510854777dff63@bidouilliste.com> <88070.1516628327@critter.freebsd.dk> <20180122145117.08173be547f5dd6fef296732@bidouilliste.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <88257.1516630050.1@critter.freebsd.dk> Content-Transfer-Encoding: quoted-printable Date: Mon, 22 Jan 2018 14:07:30 +0000 Message-ID: <88258.1516630050@critter.freebsd.dk> X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 14:07:48 -0000 -------- In message <20180122145117.08173be547f5dd6fef296732@bidouilliste.com>, Emm= anuel Vadot writes: > Using the same logic as before one could have a script starting some >pwm stuff (or simply using /etc/sysctl.conf) > Also this is not how DT is suppose to work, if the status =3D=3D >'disabled' no driver should attach. That doesn't make *any* UX sense. "disabled" indicates that it can be enabled, and there is absolutely no reason to force users to reboot, when all that stands between them and using their hardware is a random setting in a file. Explicitly kldload'ing a device-driver is as clear a "Enable it, please" instruction as you can get from the user. If you want to lock down this DT-device because some other device/pin-mux/whatever makes its use impossible, then status should not be "disabled" but "locked" or "impossible". In particular it is *horrible* UX, that you kldload a device-driver for hardware you know is there, and it just silently doesn't do anything. At the very least it should give a diagnostic. Maybe something like: "For no good reason this device is disabled, google for an hour, try to come up with a device tree overlay, reboot to install it and see if you get lucky." :-) >> > Can you please revert this part ? >> = >> Once I find out how to get similar behaviour, ie: kldload without >> having to reboot to load a DT-overlay. > > Nobody is working on that right now (that I know of). Let me know when it works, and I'll remove my hack then. In the meantime, don't load bcm283x_pwm if you don't plan on using the PWM on GPIO12 on your RPI[23]. -- = Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe = Never attribute to malice what can adequately be explained by incompetence= .