From owner-freebsd-ports@freebsd.org  Thu May 13 16:32:17 2021
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id D1920647609
 for <freebsd-ports@mailman.nyi.freebsd.org>;
 Thu, 13 May 2021 16:32:17 +0000 (UTC)
 (envelope-from portmaster@bsdforge.com)
Received: from udns.ultimatedns.net (static-24-113-41-81.wavecable.com
 [24.113.41.81])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "ultimatedns.net", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FgxyT4TdNz3NyS
 for <freebsd-ports@freebsd.org>; Thu, 13 May 2021 16:32:17 +0000 (UTC)
 (envelope-from portmaster@bsdforge.com)
Received: from ultimatedns.net (localhost [127.0.0.1])
 by udns.ultimatedns.net (8.16.1/8.16.1) with ESMTP id 14DGWZap089240;
 Thu, 13 May 2021 09:32:42 -0700 (PDT)
 (envelope-from portmaster@bsdforge.com)
MIME-Version: 1.0
Date: Thu, 13 May 2021 09:32:35 -0700
From: Chris <portmaster@bsdforge.com>
To: Christoph Moench-Tegeder <cmt@burggraben.net>
Cc: freebsd-ports <freebsd-ports@freebsd.org>
Subject: Re: pkg-fallout: License not correctly defined: defining both
 LICENSE_FILE and LICENSE_TEXT is not allowed
In-Reply-To: <YJ1PDacWsRFVHime@elch.exwg.net>
References: <50a92b1644e8fa43f16d59aa013ca10d@bsdforge.com>
 <YJ1PDacWsRFVHime@elch.exwg.net>
User-Agent: UDNSMS/17.0
Message-ID: <6a5d5af22c863c1b5284885d39bf1129@bsdforge.com>
X-Sender: portmaster@bsdforge.com
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4FgxyT4TdNz3NyS
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [0.00 / 15.00];
 ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US];
 local_wl_ip(0.00)[24.113.41.81]
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 May 2021 16:32:17 -0000

On 2021-05-13 09:08, Christoph Moench-Tegeder wrote:
> ## Chris (portmaster@bsdforge.com):
> 
>> HOWEVER the error returned by pkg-fallout@ makes absolutely no
>> sense at all, given the Makefile for the report contains only:
> 
> Foremost, that Makefile has an .include, and that's where the mess
> (for this use case) happens.
> From a quick glance, I'm not totally sure how that
> kde-icons-noia/Makefile.icons makes sense in the grand scheme of
> things (if it's that common functionality, should it live somewhere
> in Mk? if it's relevant only for a very limited number of ports, should
> it have some comments about that?), but the way it currently interacts
> with your port is not that fine: in the very least, it overwrites
> your LICENSE variables, which cannot be your intention. (Try
> "make -V LICENSE" in kde-icons-nuovoext2).
Sorry. My bad. LGPL3 is now included in the current LICENSE Templates.
So LICENSE_FILE is redundant && pkg-fallout (the ports framework) was
trying to use a "clue bat" to tell me so. ;-)

Sorry for the noise, and thanks for taking the time to reply.

--Chris
> 
> Regards,
> Christoph