From nobody Sat Aug 1 08:56:04 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBxcT4rHsz6nHjf for ; Sat, 01 Aug 2026 08:56:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBxcT3Tk8z3qj5 for ; Sat, 01 Aug 2026 08:56:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785574569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vvzbvrgqnO9XaqmjkrsebOwWnGko5m0iDYYj/n5MbS4=; b=dv/uHZ1NRkrQgr3Tzdy3qLaRsPkIAT9Iu/zxyH52duNqQW5iqNTK/mJNB6BBCN1zW78xkY PYdn3gXhzZD17GpjXseE1/iG6biU0mqvYReYzyeTf6UhoTk2pVDgjxp6RBLqNrhB/Jzlvn Ochj9HYNFVBlUodUx7Jk2aelpFPde9eg7hnET+DHvsvZFgB+Mk1eexjzN76iUIzQUt/BuC 0eCCw4Tjt++VWlX/MxJ0zSQXA8WmejFk2GqpfYcvbb2PkRFZoLAjMBpdyJGnzUhIFmUZWR jIdQjNjw9PBMfv0a6OGpXTz2xY1PlUptvDcnXVHSO6RK2Gzq29Y+xw502EkXzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785574569; a=rsa-sha256; cv=none; b=jeLyvaS7xYY4srwv5kbyUXzbwDbnpe2QZLsOCYDEzWDfIoDoO7fg+MbnQGQ/WFkxre3xSK 5Zx2jO33il9g/wRDwJ6YYRIr9SUH4tISGPhdiyd7lQdR1M0wrJbgFSx52ub5EtQVKXAzbb FJg5W9YbtzIrFMXIhzxk2tEvPzgsP3ffhAlLsUbWe+LYHGxCVDcQ86HxpuDoWlma0PuCfi EJbbqSLoJgYdMFrB3WQntESS1+hLcrDUXdMbGZu6I6S0+LMs9C18+qRlJGe2HH7jVuc+WP n2TEMl4c0WbczSINrdmqPnfRK7hifQ4+K70GLfe9YIR1TdZYbYBSgeyOQb0jXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785574569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vvzbvrgqnO9XaqmjkrsebOwWnGko5m0iDYYj/n5MbS4=; b=IV/j1BaOimcfYguJJJIYoLxDuAp0VigmFYcAnn2s8fC1tajbI2M5bB2rRTo1hTZKazr+Ni cRHOxcrOdsb1t4DVqpgxxXQ/lxs7epVw1TavMWST58Vucz7AElkmFsaE9z8eStT4jgaj/2 XlGGvmxaT3roPmXmH6wAHw+yI1Pnd/7ZM1j/K4NHy1a3C+Uof1FBAq9oP71s5eiBXDHVaH O4MSFp000m5dCoyDClWk8tA3uaLEVqToXqtR4LgcK8jeG02PHi8uNUX2cq98m9ooUyjbdw AXopDWueTe1oLlUUITbZtn5nxj1PIbxteLsD9TOnzmvL0lC/O9cnMQ3MLbfPKg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBxcT2PrXzfNt for ; Sat, 01 Aug 2026 08:56:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2742a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 01 Aug 2026 08:56:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: d2309d9d6dc6 - main - ixl: enforce the assigned VF MAC address List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d2309d9d6dc6d5a9141314652d6c96ab46a9a62c Auto-Submitted: auto-generated Date: Sat, 01 Aug 2026 08:56:04 +0000 Message-Id: <6a6db4a4.2742a.5334a318@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d2309d9d6dc6d5a9141314652d6c96ab46a9a62c commit d2309d9d6dc6d5a9141314652d6c96ab46a9a62c Author: Kevin Bowling AuthorDate: 2026-08-01 02:38:54 +0000 Commit: Kevin Bowling CommitDate: 2026-08-01 08:55:50 +0000 ixl: enforce the assigned VF MAC address When allow-set-mac is disabled, the MAC filter validation condition rejects the assigned VF unicast address while allowing any different unicast address. The equality test was accidentally inverted when this code moved to the boolean address helper. Accept multicast and the assigned unicast address, and reject other unicast addresses as intended. Fixes: 7d4dceec1030 ("ixl(4): Fix VLAN HW filtering") MFC after: 3 days --- sys/dev/ixl/ixl_pf_iov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/ixl/ixl_pf_iov.c b/sys/dev/ixl/ixl_pf_iov.c index ca2759557066..1e475e4767cc 100644 --- a/sys/dev/ixl/ixl_pf_iov.c +++ b/sys/dev/ixl/ixl_pf_iov.c @@ -1022,7 +1022,7 @@ ixl_vf_mac_valid(struct ixl_vf *vf, const uint8_t *addr) * is not its assigned MAC. */ if (!(vf->vf_flags & VF_FLAG_SET_MAC_CAP) && - !(ETHER_IS_MULTICAST(addr) || !ixl_ether_is_equal(addr, vf->mac))) + !(ETHER_IS_MULTICAST(addr) || ixl_ether_is_equal(addr, vf->mac))) return (EPERM); return (0); @@ -1824,4 +1824,3 @@ out: return (error); } -