From nobody Fri Apr 18 06:29:19 2025 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zf4c23Lj4z5tVrs for ; Fri, 18 Apr 2025 06:29:22 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zf4c12C77z3JXl for ; Fri, 18 Apr 2025 06:29:21 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744957761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jH8vIyjN8eWdZ7l3oXa4wMKc1vVde06NxeN/wVnFgUU=; b=WhE7G7FA8CQO/2GEJvrl8jmiOVVcUbGrpZLqEmIFW1eGNM8PYn3LVe9g6aIxULSC2Qz9Fd wLpBObiEIK29nfrLyzeHFH4T5VEwkJ5/WeBrfCI6/6U4+Y6vuxxRwHL894jPbVNh3Ps6HV y3ydBDM5Bqd6ftkAF5LNYAq7mqAhbEZwJ86Xwr6/fnSQnyBgL6m6RtOo7LE5uy6YQiYbl7 dWNBkHVGfMMJIJjRPP+3xw/BsDb0rmCgYyXq7V6D8F6BR0w7p+FcthmoyTZ5NS2l0UG7Zl KtXYvCWbsMBXbCV2Q0yP+xvjirw7NTXLvEx/NUf4JThNA7gmBFGEQDai+OZKRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744957761; a=rsa-sha256; cv=none; b=oNHzxQNjmWAl7dNQLYnM0dkX4ar4WQtFT6+ivINkRS0vaMuIch/dWHa9/aajsD6FM495Id 69JDdaYpisXafDFMBsN1czfYH5LrmrItAM3r28IDHmrWkT8vlbPR59ej2DksCOvgnZBhGt tkdKDN6Zu3N/Tg6L8g1ky42q2Vak7CS2Fg4Vk7cqR9X/mFQwlQJ99dCTCwTB57oBCwcX4M Ui8N1KF1S3OQ6xhZqIY0q33HRMKY82RmTeHJFkrjaG8lA1k1ePj9LbH4cwgGUp6MO5KWpz L0UV1KJyQvuP2LE1VZt4Ck4GY7iJ88R9RpjyICAAWEa9vngAzxYqaKFrg40r7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744957761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jH8vIyjN8eWdZ7l3oXa4wMKc1vVde06NxeN/wVnFgUU=; b=eQeoQT3OOB/cBDERy4XM417WwHQCB2qiT/TcA6oCKcAPy3QD9UvEac9//qpoDFaJFYt9Wm HYX8tStlP2vUh9Tu+hgNXAb/wSdx/6Zh7l2yWeLOiGXYTdokISysgKES+mh5W39fTLkeAN /sEZuJehKQMlzgK4PGYuMxBd0/US+qDh3ih5sXsA2POcTerY0ODiUHK6X26dM+y5zzh8jc V3Jr6WcElZ8wwrYdIns7YQ4et+2ap7LQjRpk2UsEAM1FxvGxxkhoyiwnP+z2CSncomhpJT zzjEbTsD3SiB3OgIJVZ+2JBy3qt5ZbxlnSYNmVMN+RyMwdgAGHLzL+PpO6G/QA== Received: from ltc.des.dev (88-177-82-251.subs.proxad.net [88.177.82.251]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Zf4c04dynzr3j for ; Fri, 18 Apr 2025 06:29:20 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 2506DEE20A; Fri, 18 Apr 2025 08:29:19 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: freebsd-net@freebsd.org Subject: Re: merge traceroute6 into traceroute In-Reply-To: (Lexi Winter's message of "Thu, 17 Apr 2025 23:44:24 +0100") References: <86ikn5b99w.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Fri, 18 Apr 2025 08:29:19 +0200 Message-ID: <86ikn26kzk.fsf@ltc.des.dev> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lexi Winter writes: > Dag-Erling Sm=C3=B8rgrav writes: > > Lexi Winter writes: > > > i have proposed a patch to merge traceroute6 into traceroute [...] > > I've only skimmed the PR but I urge you to look at sbin/ping/main.c and > > adjust your code to match. > i think you're essentially proposing what jlduran@ already proposed in > the PR. No. Please actually look at ping, particularly how it's handling DNS lookups. And please separate code from variable definitions, this isn't 1967 and you're not about to run out of paper in your teletype. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org