From owner-freebsd-hackers Thu Sep 26 01:10:55 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA07726 for hackers-outgoing; Thu, 26 Sep 1996 01:10:55 -0700 (PDT) Received: from relay.philips.nl (ns.philips.nl [130.144.65.1]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA07684 for ; Thu, 26 Sep 1996 01:10:50 -0700 (PDT) Received: (from smap@localhost) by relay.philips.nl (8.6.9/8.6.9-950414) id KAA01902; Thu, 26 Sep 1996 10:09:58 +0200 Received: from unknown(192.26.173.32) by ns.philips.nl via smap (V1.3+ESMTP) with ESMTP id sma001342; Thu Sep 26 10:06:25 1996 Received: from spooky.lss.cp.philips.com (spooky.lss.cp.philips.com [130.144.199.105]) by smtp.nl.cis.philips.com (8.6.10/8.6.10-0.9z-02May95) with ESMTP id KAA13409; Thu, 26 Sep 1996 10:09:16 +0200 Received: (from guido@localhost) by spooky.lss.cp.philips.com (8.6.10/8.6.10-0.991c-08Nov95) id KAA06708; Thu, 26 Sep 1996 10:06:11 +0200 From: Guido van Rooij Message-Id: <199609260806.KAA06708@spooky.lss.cp.philips.com> Subject: Re: new if_vx driver in incoming on freefal To: nao@sbl.cl.nec.co.jp (Naoki Hamada) Date: Thu, 26 Sep 1996 10:06:10 +0200 (MET DST) Cc: Guido.vanRooij@nl.cis.philips.com, freebsd-hackers@FreeBSD.org Reply-To: Guido.vanRooij@nl.cis.philips.com In-Reply-To: <199609260205.LAA10545@sirius.sbl.cl.nec.co.jp> from Naoki Hamada at "Sep 26, 96 11:05:15 am" X-Mailer: ELM [version 2.4ME+ PL19 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-hackers@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk Naoki Hamada wrote: > Hi. > > Guido, I cannot figure out what you intended the following change to > do. Could your tell me what you meant? > > --- vx/if_vx.c Wed Sep 25 00:45:50 1996 > +++ vx.old/if_vx.c Tue Sep 17 16:19:42 1996 > - outw(BASE + VX_COMMAND, SET_TX_AVAIL_THRESH | (len + pad + 4)); > + outw(BASE + VX_COMMAND, SET_TX_AVAIL_THRESH | ((len + pad + 4) >> 2)); > > BTW, I am now working on the new vx driver to make it select the right > connector. My 3C590C card seems now good at it, but I cannot try the > 3C595 adapter because I do not have one. Since the fast ethernet is > extremely faster than the ordinary ethernet, parameters may have to be > changed... > The reasonI changed it is because the value passed to it is set into bits 2 and higher of the register. This has the effect of multiplying by four. In order to get the correct value in, you thus shoul firts devide it by four. This is true for every threshold register (with the 3c59x cards). Applying this change to the old driver still doesn't do the job for me. (if you have the spec for the 3c59x, look at page 2-2, Large Packet Support, and on page 4-12, SetTxAvilableThresh) Can't you take my driver and extend it? Then we have a driver that looks far more like the {Net,Open}BSD one which has some straightforward advatages. -Guido