From owner-freebsd-usb@FreeBSD.ORG Sun Jan 11 17:16:46 2015 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 22651C84 for ; Sun, 11 Jan 2015 17:16:46 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9F3C79AC for ; Sun, 11 Jan 2015 17:16:45 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 729AD1FE022; Sun, 11 Jan 2015 18:16:42 +0100 (CET) Message-ID: <54B2B02A.1030808@selasky.org> Date: Sun, 11 Jan 2015 18:17:30 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joshua Ruehlig Subject: Re: [Bug 185747] [cam] [patch] fix support for USB key "Kingston DT 101 G2" References: <54B28BE3.9010501@selasky.org> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050306040005090502090003" Cc: freebsd-usb@freebsd.org X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jan 2015 17:16:46 -0000 This is a multi-part message in MIME format. --------------050306040005090502090003 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 01/11/15 17:59, Joshua Ruehlig wrote: > Tell meif you need anything else, thanks > - Josh Hi, Can you try the attached patch? --HPS --------------050306040005090502090003 Content-Type: text/x-patch; name="kingston_fix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="kingston_fix.diff" Index: sys/dev/usb/usb_freebsd.h =================================================================== --- sys/dev/usb/usb_freebsd.h (revision 276981) +++ sys/dev/usb/usb_freebsd.h (working copy) @@ -88,7 +88,7 @@ #define USB_EP0_BUFSIZE 1024 /* bytes */ #define USB_CS_RESET_LIMIT 20 /* failures = 20 * 50 ms = 1sec */ -#define USB_MAX_AUTO_QUIRK 4 /* maximum number of dynamic quirks */ +#define USB_MAX_AUTO_QUIRK 8 /* maximum number of dynamic quirks */ typedef uint32_t usb_timeout_t; /* milliseconds */ typedef uint32_t usb_frlength_t; /* bytes */ Index: sys/dev/usb/usb_freebsd_loader.h =================================================================== --- sys/dev/usb/usb_freebsd_loader.h (revision 276981) +++ sys/dev/usb/usb_freebsd_loader.h (working copy) @@ -83,7 +83,7 @@ #define USB_EP0_BUFSIZE 1024 /* bytes */ #define USB_CS_RESET_LIMIT 20 /* failures = 20 * 50 ms = 1sec */ -#define USB_MAX_AUTO_QUIRK 4 /* maximum number of dynamic quirks */ +#define USB_MAX_AUTO_QUIRK 8 /* maximum number of dynamic quirks */ typedef uint32_t usb_timeout_t; /* milliseconds */ typedef uint32_t usb_frlength_t; /* bytes */ Index: sys/dev/usb/usb_msctest.c =================================================================== --- sys/dev/usb/usb_msctest.c (revision 276981) +++ sys/dev/usb/usb_msctest.c (working copy) @@ -718,10 +718,11 @@ if (err != ERR_CSW_FAILED) goto error; - DPRINTF("Device doesn't handle synchronize cache\n"); + DPRINTF("Device doesn't handle synchronize cache " + "and prevent allow medium removal\n"); usbd_add_dynamic_quirk(udev, UQ_MSC_NO_SYNC_CACHE); - + usbd_add_dynamic_quirk(udev, UQ_MSC_NO_PREVENT_ALLOW); } else { /* @@ -748,10 +749,13 @@ goto retry_sync_cache; DPRINTF("Device most likely doesn't " - "handle synchronize cache\n"); + "handle synchronize cache nor" + "prevent allow medium removal\n"); usbd_add_dynamic_quirk(udev, UQ_MSC_NO_SYNC_CACHE); + usbd_add_dynamic_quirk(udev, + UQ_MSC_NO_PREVENT_ALLOW); } else { if (err != ERR_CSW_FAILED) goto error; @@ -796,6 +800,7 @@ usbd_add_dynamic_quirk(udev, UQ_MSC_NO_SYNC_CACHE); usbd_add_dynamic_quirk(udev, UQ_MSC_NO_TEST_UNIT_READY); + usbd_add_dynamic_quirk(udev, UQ_MSC_NO_PREVENT_ALLOW); /* Need to re-enumerate the device */ usbd_req_re_enumerate(udev, NULL); --------------050306040005090502090003--