From owner-freebsd-ports@FreeBSD.ORG Tue Dec 30 18:57:06 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 196E81065670 for ; Tue, 30 Dec 2008 18:57:06 +0000 (UTC) (envelope-from tingox@gmail.com) Received: from mail-bw0-f19.google.com (mail-bw0-f19.google.com [209.85.218.19]) by mx1.freebsd.org (Postfix) with ESMTP id 3E2498FC1B for ; Tue, 30 Dec 2008 18:57:04 +0000 (UTC) (envelope-from tingox@gmail.com) Received: by bwz12 with SMTP id 12so14476065bwz.19 for ; Tue, 30 Dec 2008 10:57:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=6GMvHVdwevgdltS0Knw2xPi+fOhZE+Ih8N99m+TOBUM=; b=O3Lm3Ng2Q6ysouCREQpgWKTuDy8XqEN5Gs28QIxgK1YkbUeftp9dUFwwhf4RIeqFcX Y0bfxPDvTVY+lGZHcxBUPIU8O3YCTCpY2/gpU0QMLOq0l1BDT9xE5BecfnlsMRKyzUyW y6PnqBU0WU6SBwdJRS/RHEi4tckyh57gX0DJI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=aj3pEVEeN9ijPtkJhfEAfCbnGtTNMVRtkm5IFrmBs8ErlmQInc+Lhp7xjCRbi5uQm0 o1xboZWs5ZiJ2mS4XMBAJ4XDl666CI5E3uBwTqm/3LxVe0IhNzggKlKc890Qx/xIJao5 CRBwn2BU8FxVCSnLR/XRgxFjqGhFzYRJBiwEM= Received: by 10.181.37.6 with SMTP id p6mr3262582bkj.29.1230663423348; Tue, 30 Dec 2008 10:57:03 -0800 (PST) Received: by 10.181.228.18 with HTTP; Tue, 30 Dec 2008 10:57:03 -0800 (PST) Message-ID: Date: Tue, 30 Dec 2008 19:57:03 +0100 From: "Torfinn Ingolfsen" To: freebsd-ports@freebsd.org In-Reply-To: <20081230183321.GD81218@hades.panopticon> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081230183321.GD81218@hades.panopticon> Subject: Re: amule 2.2.3 port - first try X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Dec 2008 18:57:06 -0000 On Tue, Dec 30, 2008 at 7:33 PM, Dmitry Marakasov wrote: > Something tells me that he meant to answer your previous message > about a patch that removes a file. I thought you're trying to make a > patch-* for ports's files/ too, before I understood that you're trying to > make a patch to a port itself. I see. I'm sorry if I have confused anyone, it wasn't intentional. > This patch looks good at a first glance, I've scheduled it to be build > in a tinderbox. Which reminds me I have to fix my own tinderbox, after the last update it doesn't run anymore. Probably just ome config files that mut be changed. BTW, do I need to run tinderd to mae the web ui work? I can't remember how it worked when it worked. :) > Btw, I'll second porttools advice, it really does much work for you, > such as patch creation and partially filling send-pr form. Sounds great, I will install it next. > Also look at portlint - it inspects a port and porints you at some > common errors. Yes, portlint says: root@kg-v2# portlint amule2 WARN: Makefile: [17]: use tab (not space) to make indentation WARN: Conflict "ed2k-hash-*" specified too broad. You should end it with a version number fragment (-[0-9]*). 0 fatal errors and 2 warnings found. root@kg-v2# portlint -a amule2 WARN: Makefile: [17]: use tab (not space) to make indentation WARN: Conflict "ed2k-hash-*" specified too broad. You should end it with a version number fragment (-[0-9]*). WARN: Makefile: manpage for chapter 1 should be listed in MAN1, even if compression is not necessary. WARN: Makefile: how about using MANLANG for designating manual language, such as "fr"? 0 fatal errors and 4 warnings found. After changing the first two reported problems, portlint now reports this: root@kg-v2# portlint amule2 looks fine. root@kg-v2# portlint -a amule2 WARN: Makefile: manpage for chapter 1 should be listed in MAN1, even if compression is not necessary. WARN: Makefile: how about using MANLANG for designating manual language, such as "fr"? 0 fatal errors and 2 warnings found. I'll work more on the port. -- Regards, Torfinn Ingolfsen