From owner-freebsd-ports@FreeBSD.ORG Thu Nov 18 18:09:17 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54EA2106566B for ; Thu, 18 Nov 2010 18:09:17 +0000 (UTC) (envelope-from eirnym@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0C20F8FC0C for ; Thu, 18 Nov 2010 18:09:15 +0000 (UTC) Received: by gxk9 with SMTP id 9so2112744gxk.13 for ; Thu, 18 Nov 2010 10:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=kKHHrJHpFDn6jhZP9557OpFhIwb8zZV8XErcAdSV/gs=; b=kG/z4ltWVA74rqHpQraRyBHWs6lZogagSJtkuY3Kh41d0floNbeb9BFNuKZrHG3fel Vm3MRqhXaNbLOeU42Sees71+f+PpIU4kSlsKrWk/Yz1uEPJc/TH1buXtIsiMhdOOcdot UST2kkVT/o/2FEmwZRb1Le3hJd4oA6eoBUbcg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=otN9GKQYH48aLBtnsiWU7Q7Gj8rgBcYsKg40WWK6nPVD2SoZN+nYlB94ZmzJpHQALJ lQ4zpGXwX00ocu7vcJi4WT9WHjs2T20agJPUqdMyAphSfQ8GNVZw9O8AvkZkCh89gecQ tGSXnH7jlaGgv4sl1ZyeqJ+roaucqNR1D0pig= Received: by 10.204.72.140 with SMTP id m12mr907146bkj.163.1290103754658; Thu, 18 Nov 2010 10:09:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.123.131 with HTTP; Thu, 18 Nov 2010 10:08:54 -0800 (PST) In-Reply-To: References: <4CE5280E.3090009@zedat.fu-berlin.de> <20101118160804.GA73849@eggman.experts-exchange.com> From: Eir Nym Date: Thu, 18 Nov 2010 21:08:54 +0300 Message-ID: To: Rob Farmer Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: ports@freebsd.org, Jason Helfman Subject: Re: Mk/bsd.command.mk: missing CSH tag X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2010 18:09:17 -0000 On 18 November 2010 21:00, Rob Farmer wrote: > On Thu, Nov 18, 2010 at 09:25, Eir Nym wrote: >> Firstly, it is optional part. > > You didn't answer my question: > > .if exists(/bin/csh) > CSH?=3D =C2=A0 /bin/csh > .else > CSH?=3D =C2=A0 # What goes here? > .endif > nope, only CSH?=3D /bin/csh without any other checks. Port should check if ${CSH} is exits in the system. And there no replacement in ports tree for this. And this variable can be in Makefile for port because it is uncommon. > And I'm aware it can be dropped using a knob. But I don't think port > maintainers should be expected to support anything other than a full > base system. This port needs csh, so it will fail if you don't have > csh. > >> and I can rewrite build script to >> make(1) or at least shell script > > Ok, great. But you are still basically saying that certain base system > utilities should be off limits because you have chosen to remove them > from your system. > If you want, you can remove tcsh(1) from your system using WITHOUT_TCSH in src.conf(5) with rebuilding system, and then removing obsolete files. > -- > Rob Farmer >