From owner-freebsd-current@FreeBSD.ORG Thu Mar 14 16:47:49 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 8692E23B for ; Thu, 14 Mar 2013 16:47:49 +0000 (UTC) (envelope-from erdgeist@erdgeist.org) Received: from elektropost.org (elektropost.org [217.13.206.130]) by mx1.freebsd.org (Postfix) with ESMTP id CD30DAC7 for ; Thu, 14 Mar 2013 16:47:48 +0000 (UTC) Received: (qmail 74549 invoked from network); 14 Mar 2013 16:47:47 -0000 Received: from elektropost.org (HELO elektropost.org) (erdgeist@erdgeist.org) by elektropost.org with CAMELLIA256-SHA encrypted SMTP; 14 Mar 2013 16:47:47 -0000 Message-ID: <5141FF33.5030108@erdgeist.org> Date: Thu, 14 Mar 2013 17:47:47 +0100 From: Dirk Engling User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130216 Thunderbird/17.0.3 MIME-Version: 1.0 To: Pawel Jakub Dawidek Subject: Re: pidfile_open incorrectly returns EAGAIN when pidfile is locked References: <513F8D20.2050707@erdgeist.org> <51417C19.9060002@erdgeist.org> <20130314084420.GH1372@garage.freebsd.pl> <201303140942.40945.jhb@freebsd.org> <20130314162958.GD1344@garage.freebsd.pl> In-Reply-To: <20130314162958.GD1344@garage.freebsd.pl> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2013 16:47:49 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 14.03.13 17:29, Pawel Jakub Dawidek wrote: > Heh, I did consider that as well, but here you check errno twice, > instead of once. Guys, is there anything wrong with the patch I > proposed? Except some obvious bike shed color issues there is nothing wrong with your patch. Regards, erdgeist -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAlFB/zIACgkQuN1wFypsMNMqzQCdHFgaP9XzsRPm8PmQA/bmXmCm G/kAn0oUrTkp80yRSpizfO4GoS/WKo+x =pCkU -----END PGP SIGNATURE-----