From owner-freebsd-bugs@FreeBSD.ORG Tue Dec 9 07:00:39 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E244716A567 for ; Tue, 9 Dec 2003 07:00:39 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1E6C43D2B for ; Tue, 9 Dec 2003 07:00:35 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hB9F0ZFY054987 for ; Tue, 9 Dec 2003 07:00:35 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hB9F0ZsO054986; Tue, 9 Dec 2003 07:00:35 -0800 (PST) (envelope-from gnats) Resent-Date: Tue, 9 Dec 2003 07:00:35 -0800 (PST) Resent-Message-Id: <200312091500.hB9F0ZsO054986@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, dada@sbox.tugraz.at Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D0FB16A4CE for ; Tue, 9 Dec 2003 06:54:25 -0800 (PST) Received: from mailrelay02.tugraz.at (mailrelay.tu-graz.ac.at [129.27.3.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5803343D28 for ; Tue, 9 Dec 2003 06:54:23 -0800 (PST) (envelope-from dada@sbox.tugraz.at) Received: from localhost (webmail01.tu-graz.ac.at [129.27.3.143]) hB9EsJ1n025939; Tue, 9 Dec 2003 15:54:19 +0100 (CET) Received: from ABRZ173.kfunigraz.ac.at (ABRZ173.kfunigraz.ac.at ; Tue, 9 Dec 2003 15:54:20 +0100 Message-Id: <20031209155420.owco000444w4g0g4@webmail.tugraz.at> Date: Tue, 9 Dec 2003 15:54:20 +0100 From: dada@sbox.tugraz.at To: freebsd-gnats-submit@FreeBSD.org Subject: bin/60079: realpath(3) accepts zero size symbolic links X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2003 15:00:40 -0000 X-List-Received-Date: Tue, 09 Dec 2003 15:00:40 -0000 >Number: 60079 >Category: bin >Synopsis: realpath(3) accepts zero size symbolic links >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Dec 09 07:00:35 PST 2003 >Closed-Date: >Last-Modified: >Originator: Martin Kammerhofer >Release: FreeBSD 4.9-STABLE i386 >Organization: Graz University >Environment: System: FreeBSD Martin.liebt.Susi 4.9-STABLE FreeBSD 4.9-STABLE #0: Thu Nov 20 21:46:53 CET 2003 toor@Martin.liebt.Susi:/usr/obj/usr/src/sys/LEND4 i386 Applies to -current and -stable. >Description: The libc realpath(3) routine accepts zero size symbolic links without returning any error indication. Since namei(9) will never accept such a path this behaviour is misleading and could confuse applications. BTW Revision 1.13 of src/lib/libc/stdlib/realpath.3 needs a MFC. >How-To-Repeat: /var/tmp$ ln -s "" ZEROLINK /var/tmp$ realpath ZEROLINK /var/tmp /var/tmp$ realpath ZEROLINK/vi.recover /var/tmp/vi.recover >Fix: --- src/lib/libc/stdlib/realpath.c.orig Tue Dec 9 12:48:48 2003 +++ src/lib/libc/stdlib/realpath.c Tue Dec 9 12:52:27 2003 @@ -149,11 +149,14 @@ return (NULL); } slen = readlink(resolved, symlink, sizeof(symlink) - 1); - if (slen < 0) + if (slen <= 0) { + if (slen == 0) + errno = ENOENT; return (NULL); + } symlink[slen] = '\0'; if (symlink[0] == '/') { - resolved[1] = 0; + resolved[1] = '\0'; resolved_len = 1; } else if (resolved_len > 1) { /* Strip the last path component. */ >Release-Note: >Audit-Trail: >Unformatted: