From owner-freebsd-current@FreeBSD.ORG Tue Dec 24 15:51:09 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7C031D6A; Tue, 24 Dec 2013 15:51:09 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 52CA61ACC; Tue, 24 Dec 2013 15:51:09 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3455DB95D; Tue, 24 Dec 2013 10:51:08 -0500 (EST) From: John Baldwin To: Roger Pau Monne Subject: Re: [PATCH v7 09/19] xen: add a apic_enumerator for PVH Date: Tue, 24 Dec 2013 10:22:22 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <1387479296-33389-1-git-send-email-roger.pau@citrix.com> <1387479296-33389-10-git-send-email-roger.pau@citrix.com> In-Reply-To: <1387479296-33389-10-git-send-email-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201312241022.22181.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 24 Dec 2013 10:51:08 -0500 (EST) Cc: xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, gibbs@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Dec 2013 15:51:09 -0000 On Thursday, December 19, 2013 1:54:46 pm Roger Pau Monne wrote: > --- > sys/conf/files.amd64 | 1 + > sys/x86/xen/mptable.c | 136 My only request would be to not call this 'mptable.c' as it has nothing to do with the MP Table spec. (I realize the older Xen code made this error previously.) You could maybe call it sys/x86/xen/pv_vcpu.c or some such. -- John Baldwin