From owner-svn-src-head@FreeBSD.ORG  Thu Jul  8 05:11:07 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19CF7106566B;
	Thu,  8 Jul 2010 05:11:07 +0000 (UTC)
	(envelope-from bruce@cran.org.uk)
Received: from muon.cran.org.uk (muon.cran.org.uk [204.109.60.94])
	by mx1.freebsd.org (Postfix) with ESMTP id D0F388FC17;
	Thu,  8 Jul 2010 05:11:06 +0000 (UTC)
Received: from unknown (client-82-31-2-50.midd.adsl.virginmedia.com
	[82.31.2.50])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by muon.cran.org.uk (Postfix) with ESMTPSA id 8E0FE5D42;
	Thu,  8 Jul 2010 05:10:57 +0000 (UTC)
Date: Thu, 8 Jul 2010 06:11:01 +0100
From: Bruce Cran <bruce@cran.org.uk>
To: Randi Harper <randi@FreeBSD.org>
Message-ID: <20100708061101.00005e8b@unknown>
In-Reply-To: <201007072253.o67MrxkL028447@svn.freebsd.org>
References: <201007072253.o67MrxkL028447@svn.freebsd.org>
X-Mailer: Claws Mail 3.7.4cvs1 (GTK+ 2.16.0; i586-pc-mingw32msvc)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org
Subject: Re: svn commit: r209782 - head/usr.sbin/sysinstall
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jul 2010 05:11:07 -0000

On Wed, 7 Jul 2010 22:53:59 +0000 (UTC)
Randi Harper <randi@FreeBSD.org> wrote:

> +	bzero(&server, sizeof(struct sockaddr_in));
> +	server.sin_family = AF_INET;
> +	server.sin_port = htons(514);
> +	bcopy((char *)hp->h_addr, (char *)&server.sin_addr,
> hp->h_length); +
> +	asprintf(&line, "<%d>%s", LOG_NOTICE, errstr);
> +	sendto(sock, line, strlen(line), 0, (struct sockaddr
> *)&server, 
> +	    sizeof(struct sockaddr_in));
> +

I'm wondering if server.sin_len should be set too? sendto in
uipc_syscalls.c appears to want it set (it calls sendit() which calls
getsockaddr() which gets passed mp->msg_namelen).

-- 
Bruce