From owner-freebsd-ppc@freebsd.org Fri Jan 10 04:45:22 2020 Return-Path: Delivered-To: freebsd-ppc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 389E4223AF6 for ; Fri, 10 Jan 2020 04:45:22 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47v9QT1Fr3z49pD; Fri, 10 Jan 2020 04:45:20 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lf1-x12e.google.com with SMTP id f15so430467lfl.13; Thu, 09 Jan 2020 20:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BLgVoQppjgdxYwYi/UAzYAETiw0OEkwANVlV+aHq5BA=; b=e3aKmLV2svCrn5xMc1VbEdk75zBoFxxOR+EGw7UICnVGXZs+b7tKel1A72FRxXYwmq qAJPVprZKP3Y5wIw9TcGW/mMzOw2L8Gb79qIU+PHq/HvmbHQvpn/+m3V4guKHiDAIiKQ O4oqf76E5Ud8AZyFpcboG2Eq1CZL74mnS7L1bfHxK+/QflzsV+iA9Obe7trOBj/eYCU5 au7epK2+12HuygR6mU9KNsvYtuTxbSBKiwV7DleDwHjAz5PHN3oFaUnX3XCH86BTxZFN bEbF16SxricZK3PqHd9NA1+QQg0ZlP+s9/aTEyOXgiemdDC4/KPFKMfadLkXwrtM/9Ic wEiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BLgVoQppjgdxYwYi/UAzYAETiw0OEkwANVlV+aHq5BA=; b=UiElm5s/iLY9rUtnuypFbroVLyW6LAN+wKCRQqOheDOjDWv4uo15uNoHJWr7eObqQZ wZCXSAdZyfasrTNRL+zUc9qQZ4bW541H36MsKuVDqytDPhz9V3nRBMEGK6IukWsGECvF Rl5St4zGf2G0AZkTXBbnq6rm4lEV257KWd2r57kno/3qqXB9RT0BV+m/9ShHQNo63AR3 D5jV+KC+lcCiAaOpTe7scw7NZ0FdJ74pS1WOu09JC5VQbS+YvkeGHXZ9a2CLWLMdSkZO 6DXmg0pujjsVmoASqHYvPOTWjmjndJTk7koqgVPCXNsBhjStS4ifTeOfXWrnJ+rYqvzw 62Vw== X-Gm-Message-State: APjAAAWXam0R58lA3hBptxZPdK8UrppMBaqIv/WxRKFOVHB6ITiaFkg6 BZlL04V/BK8ISKQ4TfGrBcLFQnJeM+fajTVYZgE= X-Google-Smtp-Source: APXvYqxN3WkHWxzvRjymYlgVHSbC6uToV8/UxEI1gvL8SmzfGk1GwCIPUeBzTDA6wrf1Ian6YXRgOYx/9bZLPXslveI= X-Received: by 2002:a19:f811:: with SMTP id a17mr888666lff.182.1578631518548; Thu, 09 Jan 2020 20:45:18 -0800 (PST) MIME-Version: 1.0 References: <022334D3-B60E-440F-A514-8D8002B65CB4.ref@yahoo.com> <022334D3-B60E-440F-A514-8D8002B65CB4@yahoo.com> In-Reply-To: From: Justin Hibbits Date: Thu, 9 Jan 2020 22:45:09 -0600 Message-ID: Subject: Re: A possible unbounded loop in moea_sync_icache: why sys/vm/mlock_test:mlock__copy_on_write_vnode fails? To: Mark Millard Cc: Leandro Lupori , FreeBSD PowerPC ML , "bdragon@freebsd.org" X-Rspamd-Queue-Id: 47v9QT1Fr3z49pD X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=e3aKmLV2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of chmeeedalf@gmail.com designates 2a00:1450:4864:20::12e as permitted sender) smtp.mailfrom=chmeeedalf@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[11]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FREEMAIL_TO(0.00)[yahoo.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[e.2.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-8.94), ipnet: 2a00:1450::/32(-2.61), asn: 15169(-1.85), country: US(-0.05)]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2020 04:45:22 -0000 On Thu, Jan 9, 2020, 17:31 Mark Millard wrote: > > > On 2020-Jan-9, at 03:12, Leandro Lupori > wrote: > > > Interesting, this looks like the same issue that was fixed on 64-bit > some time ago: https://reviews.freebsd.org/D19149. > > I changed my local code to use va+1 as in that update > and can confirm that I now get: > > # kyua test -k /usr/tests/Kyuafile sys/vm/mlock_test > sys/vm/mlock_test:mlock__copy_on_write_anon -> passed [0.018s] > sys/vm/mlock_test:mlock__copy_on_write_vnode -> passed [0.008s] > sys/vm/mlock_test:mlock__truncate_and_resize -> passed [0.019s] > sys/vm/mlock_test:mlock__truncate_and_unlock -> passed [0.019s] > > > > On Thu, Jan 9, 2020 at 3:03 AM Mark Millard via freebsd-ppc at freebsd.org> wrote: > >> . . . > >> The code in question: > >> > >> static void > >> moea_sync_icache(mmu_t mmu, pmap_t pm, vm_offset_t va, vm_size_t sz) > >> { > >> struct pvo_entry *pvo; > >> vm_offset_t lim; > >> vm_paddr_t pa; > >> vm_size_t len; > >> > >> PMAP_LOCK(pm); > >> while (sz > 0) { > >> lim = round_page(va); > > The above line is where I changed the va to be > va+1 . > > >> len = MIN(lim - va, sz); > >> pvo = moea_pvo_find_va(pm, va & ~ADDR_POFF, NULL); > >> if (pvo != NULL) { > >> pa = (pvo->pvo_pte.pte.pte_lo & PTE_RPGN) | > >> (va & ADDR_POFF); > >> moea_syncicache(pa, len); > >> } > >> va += len; > >> sz -= len; > >> } > >> PMAP_UNLOCK(pm); > >> } > > > > > === > Mark Millard > marklmi at yahoo.com > ( dsl-only.net went > away in early 2018-Mar) > Hi Mark, I just committed the fix as r356595. - Justin >