From nobody Thu Apr 23 19:17:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g1m7w3cxqz6bMsB for ; Thu, 23 Apr 2026 19:17:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g1m7w2wbRz3jQt for ; Thu, 23 Apr 2026 19:17:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776971868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cQU9RJ+dUUvTMYfOgpdx/K7vbVJ2bdYYrazStNzrIsc=; b=lp0dtesKoZzHnfIiIjY680WkKc2uXX69F+AeA/bVfQB3Jx4Kagfst+OohDg1DDHsi9lu5i fkeb4F/J7IhRbMxq1Q0lo0yz9i6wC4Ydy53/JG2mpIzfFDHjTLRpRGsqlQcrdvqdEe06aO Gox9YvSflL5QAk10DZ5fA+WYRratXkPgOzJI5uVfYvojoVsBZvwSlfF/vENFF2l7KzdL7s TZ2ZgKZtJumHGeQf1MZXkOCAbS2BK9cmJBmRhH06U5+exVeR3cDyuK0wKYr5b35/CX7pu4 3VpTjtaW26zN+rErgbYUXhWRs/g89c5xSmWrUDcgMMPjD+dZ1LIyMn8pEppnHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776971868; a=rsa-sha256; cv=none; b=AKZlzrbeTMPobVCnxAhOTCk4Yiv6cOwgZiikf3tyLX3VVJhZyInbOjUMWA+nvC4+rgx1oM Bn+k+9tbrjrJ1MpDO7655Ix8NbdVhrmAblG0hgJXn7FBe9EzduiP+jBeD0lue1MUFz4z+w 9Il5vFCUGi3Y/zVzDlGbGLt4zcWqEumVY40vaBDUk87YtymtixGqFBY+fPCaVH/mjJREZK TzLOUB71UnE7zkUhXPwab0XzyQ/HT/w5SvQZWYicGza1xP5oGpZy7zgncPSu7J7MSVAJ0d JusKQGcPA6CexqdCvdVo52bFZ71CRdr8Acvz4nfJg4AT7MKGQ52McgxcuBZUJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776971868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cQU9RJ+dUUvTMYfOgpdx/K7vbVJ2bdYYrazStNzrIsc=; b=eekDBLhisy4SJrMNZMpdBHLky3Z9Q9yuk6msGnJ2jWO2Q3S6DWW2+RtoPyFcxnMWBJWhwP K6r29bdAQoUKLplWCav5Gfab4iHOXttqzy4nqqcHlkLxXe8/Wnpa0owG9mTncrz40CajfN fCUy9JbQeX5ulcqW4NUtylq7j9EMVY2lG1/bIN+PTn+N20abgBJuOnuDnfR/YxO4/N7VFP saijwLSDehpaQtk6pPVesDH7Hn7neGYGeWCvoH7NaSRljTqJvQPbTcOrsfMEW1Yt5TjCbl IFwKVtaAe6qV5zmZ0de92bJtv+gVTjp2CtM4lk533kxmSMDlTMnuIoZUYcSWEw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g1m7w21BRzVFK for ; Thu, 23 Apr 2026 19:17:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1cf1b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 23 Apr 2026 19:17:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 3df5cc33d894 - main - ctld: Ports without a portal group are not dummy ports List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3df5cc33d894edd6b0ae87e51f0e35c3501fb907 Auto-Submitted: auto-generated Date: Thu, 23 Apr 2026 19:17:48 +0000 Message-Id: <69ea705c.1cf1b.2947c10e@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=3df5cc33d894edd6b0ae87e51f0e35c3501fb907 commit 3df5cc33d894edd6b0ae87e51f0e35c3501fb907 Author: John Baldwin AuthorDate: 2026-04-23 19:16:08 +0000 Commit: John Baldwin CommitDate: 2026-04-23 19:16:08 +0000 ctld: Ports without a portal group are not dummy ports The default implementation of is_dummy should return false. Only portal group ports should possibly return true. PR: 293076 Reported by: Ken J. Thomson Fixes: 6acc7afa34aa ("ctld: Convert struct port to a hierarchy of C++ classes") Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D56524 --- usr.sbin/ctld/ctld.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/ctld/ctld.hh b/usr.sbin/ctld/ctld.hh index 11bda5f25f8c..a1bd5a62cf3b 100644 --- a/usr.sbin/ctld/ctld.hh +++ b/usr.sbin/ctld/ctld.hh @@ -269,7 +269,7 @@ struct port { virtual struct auth_group *auth_group() const { return nullptr; } virtual struct portal_group *portal_group() const { return nullptr; } - virtual bool is_dummy() const { return true; } + virtual bool is_dummy() const { return false; } virtual void clear_references();