From owner-cvs-src@FreeBSD.ORG Wed Aug 6 16:31:48 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 908CD1065673; Wed, 6 Aug 2008 16:31:48 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 332A38FC15; Wed, 6 Aug 2008 16:31:48 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m76GUNMD002442; Wed, 6 Aug 2008 10:30:23 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 06 Aug 2008 10:30:41 -0600 (MDT) Message-Id: <20080806.103041.-749248634.imp@bsdimp.com> To: sam@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <4899C437.3090506@freebsd.org> References: <200808060734.m767Yoob077994@repoman.freebsd.org> <4899C437.3090506@freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pccard pccard.c pccardvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2008 16:31:48 -0000 In message: <4899C437.3090506@freebsd.org> Sam Leffler writes: : Warner Losh wrote: : > imp 2008-08-06 07:34:35 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/pccard pccard.c pccardvar.h : > Log: : > SVN rev 181342 on 2008-08-06 07:34:35Z by imp : > : > Unify the initial card probe/attach procedure with the kldload : > procedure. There were some subtle differences before that could lead : > to a variety of bugs, including resources being lost (in one case : > forever). pccard_probe_and_attach_card does this now, and includes : > comments about what's going on and why, since it isn't obvious from : > the code. Please let me know if I've missed anything... : > : > Provide a new function called pccard_select_cfe that allows drivers to : > select which configuration entry to use. This is needed for some : > older pre-MFC standard cards with many functions that want to activate : > all their functions by selecting alternative entries, or to work : > around broken ones. pccard_select_cfe will migrate into the : > pccard_if.m interface as its interface stabilizes to keep all the : > pccard drivers from referencing any symbols in the pccard.ko module : > directly. : > : > : : Are there any specific bugs this fixes? For example I have seen cases : where ejecting a wireless card leaves the ifnet around. This won't fix that. I've only seen this when the detach routine blocks... But if there's other times... : I also have a : wireless card that does not probe (we've discsussed it; looks like an : issue not powering on the socket). That's also something I don't think this will fix. This is a problem in the pccard/cardbus bridge code somewhere, I think. I haven't been able to reproduce this locally, or hook up with you in the bay area. The specific bugs that I've seen are that there's an ordering in which you can have a 16-bit PC Card with resources owned by the pccard layer, and then a driver is loaded and fails and then you get error messages when the card is ejected. Warner