From owner-freebsd-hackers@FreeBSD.ORG Mon Jun 27 10:59:28 2011 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 103181065672; Mon, 27 Jun 2011 10:59:28 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from tower.berklix.org (tower.berklix.org [83.236.223.114]) by mx1.freebsd.org (Postfix) with ESMTP id 793048FC13; Mon, 27 Jun 2011 10:59:26 +0000 (UTC) Received: from park.js.berklix.net (pD9FBE654.dip.t-dialin.net [217.251.230.84]) (authenticated bits=0) by tower.berklix.org (8.14.2/8.14.2) with ESMTP id p5RAxP8Q012905; Mon, 27 Jun 2011 10:59:25 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by park.js.berklix.net (8.13.8/8.13.8) with ESMTP id p5RAxFKY020533; Mon, 27 Jun 2011 12:59:17 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.4/8.14.4) with ESMTP id p5RAxAsG022832; Mon, 27 Jun 2011 10:59:15 GMT (envelope-from jhs@fire.js.berklix.net) Message-Id: <201106271059.p5RAxAsG022832@fire.js.berklix.net> To: Tim Kientzle From: "Julian H. Stacey" Organization: http://www.berklix.com BSD Unix Linux Consultancy, Munich Germany User-agent: EXMH on FreeBSD http://www.berklix.com/free/ X-URL: http://www.berklix.com In-reply-to: Your message "Sat, 25 Jun 2011 09:41:36 PDT." <31D907F2-1F80-40B4-BDC3-486E3F988FE7@freebsd.org> Date: Mon, 27 Jun 2011 12:59:10 +0200 Sender: jhs@berklix.com Cc: hackers@freebsd.org, portsmaster@freebsd.org Subject: Re: tar has deficient error handling. send-pr fix sent 31 Jan 2011 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 10:59:28 -0000 Hi, Reference: > From: Tim Kientzle > Date: Sat, 25 Jun 2011 09:41:36 -0700 > Message-id: <31D907F2-1F80-40B4-BDC3-486E3F988FE7@freebsd.org> Tim Kientzle wrote: > Thanks for the reminder Julian. > > I've just committed a fix to trunk that I'd appreciate if you could look at. > > > Might be nice if someone else would read through tar. > > More eyes are always better! I'd especially appreciate help > improving the test suite for tar. I've put a lot of work into > the test suite for libarchive, but the tar front-end has seen > less effort in this area. > > Cheers, > > Tim > > On Jun 23, 2011, at 9:20 AM, Julian H. Stacey wrote: > > > FreeBSD tar has deficient error handling. I sent a fix 31 Jan 2011 > > http://www.freebsd.org/cgi/query-pr.cgi?pr=154407 > > Please commit the fix or write & commit a better fix. > > > > As error codes ignored, I wonder if other poor coding may lurk in tar. > > Might be nice if someone else would read through tar. > > > > ports/ : Tar allows some errors in ports pkg-list to go un-noticed. > > Using make package, tar fails to see errors, fails to return error > > to make, some pkg-list not checked properly & accumulate errors, > > A bunch of errors will probably show up when tar is fixed, the > > more the longer we do nothing. ( I can't remember which pkg-list > > are broken, I've not kept note, The solution is to read tar & > > commit a fix to tar ASAP) > > > > Cheers, > > Julian Thanks Tim, I will look & get back to you. Re test suite: Maybe you can add something to check for errors not caught by original tar + `cd ports/www/apache13 ; make package` ( Files not found, tar didn't notice. I guess a macro with pkg-plist was corrupting paths fed to tar ) Cheers, Julian -- Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com Reply below, not above; Indent with "> "; Cumulative like a play script. Format: Plain text. Not HTML, multipart/alternative, base64, quoted-printable.