From owner-cvs-all@FreeBSD.ORG Sat Aug 21 18:25:22 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06F4E16A4CE; Sat, 21 Aug 2004 18:25:22 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99A2E43D1F; Sat, 21 Aug 2004 18:25:21 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.51] (adsl-64-171-186-94.dsl.snfc21.pacbell.net [64.171.186.94]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i7LIPH8U006491; Sat, 21 Aug 2004 11:25:18 -0700 Message-ID: <4127938E.5050004@root.org> Date: Sat, 21 Aug 2004 11:25:18 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <200408201652.i7KGqiRb030057@repoman.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_resource.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2004 18:25:22 -0000 Dag-Erling Smørgrav wrote: > Nate Lawson writes: > >> "Loop through all current resources to see if the new one overlaps >> any existing ones. If so, the old one always takes precedence and >> the new one is adjusted (or rejected). We check for three cases: >> >> 1. Tail of new resource overlaps head of old resource: truncate the >> new resource so it is contiguous with the start of the old. >> 2. New resource wholly contained within the old resource: error. >> 3. Head of new resource overlaps tail of old resource: truncate the >> new resource so it is contiguous, following the old." > > > What about the fourth case: new resource wholly contains old resource? For this code, the new resource's tail is truncated. That case didn't need to be handled for intra-device resources. However, I've found a system that has 2 separate sysresource devices with overlapping resources and that requires a bit larger change, unfortunately. -- Nate