From owner-freebsd-threads@freebsd.org  Mon Feb 15 21:39:27 2016
Return-Path: <owner-freebsd-threads@freebsd.org>
Delivered-To: freebsd-threads@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04348AA8653
 for <freebsd-threads@mailman.ysv.freebsd.org>;
 Mon, 15 Feb 2016 21:39:27 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id EA02633C
 for <freebsd-threads@freebsd.org>; Mon, 15 Feb 2016 21:39:26 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id E50B4AA8650; Mon, 15 Feb 2016 21:39:26 +0000 (UTC)
Delivered-To: threads@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E48F8AA864E;
 Mon, 15 Feb 2016 21:39:26 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net
 [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f])
 by mx1.freebsd.org (Postfix) with ESMTP id D025F33A;
 Mon, 15 Feb 2016 21:39:26 +0000 (UTC)
 (envelope-from vangyzen@FreeBSD.org)
Received: from ford.home.vangyzen.net (unknown [76.164.15.242])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id 8D38F56B12;
 Mon, 15 Feb 2016 15:39:19 -0600 (CST)
Subject: Re: libthr shared locks
To: Konstantin Belousov <kostikbel@gmail.com>, threads@freebsd.org,
 arch@freebsd.org
References: <20151223172528.GT3625@kib.kiev.ua> <56BE69B8.9020808@FreeBSD.org>
From: Eric van Gyzen <vangyzen@FreeBSD.org>
X-Enigmail-Draft-Status: N1110
Message-ID: <56C24586.9050906@FreeBSD.org>
Date: Mon, 15 Feb 2016 15:39:18 -0600
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <56BE69B8.9020808@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads/>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2016 21:39:27 -0000

On 02/12/16 05:24 PM, Eric van Gyzen wrote:
> On 12/23/2015 11:25, Konstantin Belousov wrote:
>> The implementation in the patch
>> https://www.kib.kiev.ua/kib/pshared/pshared.1.patch
>> gives shared mutexes, condvars, rwlocks and barriers.
> I reviewed everything except kern_umtx.c, which I plan to review on
> Monday.

My only comment on kern_umtx.c is, why are the permission checks compiled out?

I also reviewed versions 2 and 3; the revisions look fine.

Thanks for the chance to review, and for waiting for me to find time.

Eric