Date: Tue, 27 Jul 1999 18:25:43 +0200 (SAST) From: Robert Nordier <rnordier@nordier.com> To: des@yes.no (Dag-Erling Smorgrav) Cc: hackers@FreeBSD.ORG Subject: Re: replacing grep(1) Message-ID: <199907271625.SAA05638@c2-10-dbn.dial-up.net> In-Reply-To: <xzpd7xeb9xc.fsf@des.follo.net> from Dag-Erling Smorgrav at "Jul 27, 1999 01:37:35 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> Jamie Howard (howardjp@wam.umd.edu), with a little help from yours
> truly, has written a BSD-licensed version of grep(1) which has all the
> functionality of our current (GPLed) implementation, plus a little
> more, in one seventh the source code and one fourth the binary code.
> I move that we replace GNU grep in our source tree with this
> implementation, once it's been reviewed by all concerned parties.
A couple of general problems:
o Too many diagnostics have "Undefined error: 0" appended.
Particularly in the case of "err(2, re_error)" in file.c,
you probably want to look at using errx() instead.
o Errors other than "no match" need to return a exit status
of 2: some in file.c and util.c are returning 1.
A more general concern is whether Henry Spencer's regex routines
-- at least in our present "alpha-quality" version -- are up to
supporting a grep without much further debugging. I don't recall
many of the problems I found when I last looked at these, though
here are two, after 5 minutes playing:
echo xx | grep '\(x\{1,2\}\)\1'
echo x | grep '[--x]'
--
Robert Nordier
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199907271625.SAA05638>