From owner-freebsd-bugs Mon Jul 8 11:30:04 1996 Return-Path: owner-bugs Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA27822 for bugs-outgoing; Mon, 8 Jul 1996 11:30:04 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA27808; Mon, 8 Jul 1996 11:30:02 -0700 (PDT) Date: Mon, 8 Jul 1996 11:30:02 -0700 (PDT) Message-Id: <199607081830.LAA27808@freefall.freebsd.org> To: freebsd-bugs Cc: From: "Gary Palmer" Subject: Re: misc/1376: if_tun.c does not init obytes and ibytes Reply-To: "Gary Palmer" Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk The following reply was made to PR misc/1376; it has been noted by GNATS. From: "Gary Palmer" To: risner@stdio.com Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: misc/1376: if_tun.c does not init obytes and ibytes Date: Mon, 08 Jul 1996 19:25:56 +0100 Charlie Root wrote in message ID <199607080540.FAA00653@generations.stdio.com>: > >Fix: > 117d116 > < ifp->if_ibytes = 0; > 119d117 > < ifp->if_obytes = 0; > I think this should be fine. No, the patch is reversed :-) The correct way is probably to either bzero/memset the structure array to be all 0's, or to ensure that the array gets dumped into the zero-initialised area of the kernel. No doubt Bruce has comments on the above :-) Gary -- Gary Palmer FreeBSD Core Team Member FreeBSD: Turning PC's into workstations. See http://www.FreeBSD.ORG/ for info