Date: Sun, 22 Mar 2020 23:40:23 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: Kyle Evans <kevans@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>, Kubilay Kocak <koobs@FreeBSD.org>, vbox@FreeBSD.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528258 - in head/emulators/virtualbox-ose: . files Message-ID: <alpine.LSU.2.21.2003222329250.4184@anthias.pfeifer.com> In-Reply-To: <202003120041.02C0fXkP049507@repo.freebsd.org> References: <202003120041.02C0fXkP049507@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 12 Mar 2020, Kyle Evans wrote: > Log: > emulators/virtualbox-ose: use contemporary GCC instead of old llvm This patch does not exactly do that. =:o > +# machine/atomic.h may use features that are only available in GCC9. This is > +# a workaround, anyways- we should be expressing USES= compiler:c++14-lang, but > +# contemporary clang miscompiles virtualbox in some fashion and yields runtime > +# breakage. > +USE_GCC= any USE_GCC=any allows using the age old, rotten, GCC 4.2 based system compiler where still present. This is practically not the case with ONLY_FOR_ARCHS= i386 amd64 which this port also specifies, but that is a subtle and indirect approach. (Where there is no /usr/bin/gcc USE_GCC=any degenerates to USE_GCC=yes, so the two are practically equivalent here, but still the USE_GCC=yes form is the one requiring a current version.) Okay to change this to USE_GCC=yes? Gerald PS: How do patches to this port actually get approved? The log has hardly any Approved by-s.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.2003222329250.4184>