From owner-freebsd-audit  Tue Mar 27  9:20:59 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88])
	by hub.freebsd.org (Postfix) with ESMTP id 7047D37B719
	for <freebsd-audit@freebsd.org>; Tue, 27 Mar 2001 09:20:56 -0800 (PST)
	(envelope-from eric@meow.osd.bsdi.com)
Received: (from eric@localhost)
	by meow.osd.bsdi.com (8.11.2/8.11.2) id f2RHKq456615
	for freebsd-audit@freebsd.org; Tue, 27 Mar 2001 09:20:52 -0800 (PST)
	(envelope-from eric)
Date: Tue, 27 Mar 2001 09:20:52 -0800
From: Eric Melville <eric@meow.osd.bsdi.com>
To: freebsd-audit@freebsd.org
Subject: [murray@osd.bsdi.com: Re: quick patch to window(1)]
Message-ID: <20010327092052.A56508@meow.osd.bsdi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

----- Forwarded message from Murray Stokely <murray@osd.bsdi.com> -----

Date: Tue, 27 Mar 2001 01:35:40 -0800 (PST)
From: Murray Stokely <murray@osd.bsdi.com>
To: Eric Melville <eric@meow.osd.bsdi.com>
Subject: Re: quick patch to window(1)
In-Reply-To: <20010326193527.A35817@meow.osd.bsdi.com>

  Just because this is security related you should probably throw it by
-audit first even though its so simple.  Kris K and everyone are
generally good at replying to people for this sort of thing.  There is
a lot of discussion on that list about the use of these functions so
they will have strong opinions about how to do it right.

	  - Murray

On Mon, 26 Mar 2001, Eric Melville wrote:

% A week ago I had a nice patch for mail(1) too, but mikeh did something
% similar and committed it about two days ago. Awww :/
%
% This is really simple and brain-dead, and it's mostly just to keep from
% using mktemp(3) (which is deprecated, etc).
%
% Index: scanner.c
% ===================================================================
% RCS file: /home/ncvs/src/usr.bin/window/scanner.c,v
% retrieving revision 1.3
% diff -r1.3 scanner.c
% 290c290
% < 			    && (cx.x_val.v_str = str_cpy(buf)) == 0) {
% ---
% > 			    && (cx.x_val.v_str = (void *)str_cpy(buf)) == 0) {
% Index: wwterminfo.c
% ===================================================================
% RCS file: /home/ncvs/src/usr.bin/window/wwterminfo.c,v
% retrieving revision 1.4
% diff -r1.4 wwterminfo.c
% 67,68c67
% < 	mktemp(wwterminfopath);
% < 	if (mkdir(wwterminfopath, 0755) < 0 ||
% ---
% > 	if (mkdtemp(wwterminfopath) < 0 ||
%


	- Murray


----- End forwarded message -----

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message