From owner-freebsd-current@FreeBSD.ORG  Sun Sep  7 07:16:17 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 90E641065672;
	Sun,  7 Sep 2008 07:16:17 +0000 (UTC)
	(envelope-from marcus@FreeBSD.org)
Received: from creme-brulee.marcuscom.com (unknown
	[IPv6:2001:470:1f00:ffff::1279])
	by mx1.freebsd.org (Postfix) with ESMTP id 103D48FC12;
	Sun,  7 Sep 2008 07:16:16 +0000 (UTC)
	(envelope-from marcus@FreeBSD.org)
Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com
	[IPv6:2001:470:1f00:2464::4])
	by creme-brulee.marcuscom.com (8.14.2/8.14.2) with ESMTP id
	m877HkuE044499; Sun, 7 Sep 2008 03:17:46 -0400 (EDT)
	(envelope-from marcus@FreeBSD.org)
From: Joe Marcus Clarke <marcus@FreeBSD.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
In-Reply-To: <20080907070916.GA2250@garage.freebsd.pl>
References: <1220770049.10898.40.camel@shumai.marcuscom.com>
	<20080907070916.GA2250@garage.freebsd.pl>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-P70k3ICkEO0r2RIAncnY"
Organization: FreeBSD, Inc.
Date: Sun, 07 Sep 2008 03:16:22 -0400
Message-Id: <1220771782.10898.42.camel@shumai.marcuscom.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 FreeBSD GNOME Team Port 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS
	autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	creme-brulee.marcuscom.com
Cc: current <current@FreeBSD.org>
Subject: Re: Crash when loading zfs.ko
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Sep 2008 07:16:17 -0000


--=-P70k3ICkEO0r2RIAncnY
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 2008-09-07 at 09:09 +0200, Pawel Jakub Dawidek wrote:
> On Sun, Sep 07, 2008 at 02:47:29AM -0400, Joe Marcus Clarke wrote:
> > I'm seeing a very reproducible crash when the ZFS kernel module is
> > loaded with today's -CURRENT.  I think it has to do with an extra
> > VOP_UNLOCK() call.  Here is a backtrace:
> >=20
> > http://www.marcuscom.com/downloads/zfs.jpg
> >=20
> > And here is my proposed patch to fix it:
> >=20
> > http://www.marcuscom.com/downloads/zfs_znode.c.diff
>=20
> Can you try this patch instead?
>=20
> 	http://people.freebsd.org/~pjd/patches/zfs_znode.c.patch

Yeah, I realized after I sent the email we need the UNLOCK, we were just
unlocking the wrong thing.  I tried a similar one, and it worked.
Thanks.

Joe

>=20
--=20
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome

--=-P70k3ICkEO0r2RIAncnY
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEABECAAYFAkjDf8YACgkQb2iPiv4Uz4eEOQCfaAomq/wjtPu4tJKyb0Eu4w1W
+KsAoK+HKj0bG/oySY7pzdxxMD3a5p+I
=9WUt
-----END PGP SIGNATURE-----

--=-P70k3ICkEO0r2RIAncnY--