From owner-cvs-all Mon Nov 13 21:34:34 2000 Delivered-To: cvs-all@freebsd.org Received: from white.dogwood.com (white.dogwood.com [63.96.228.130]) by hub.freebsd.org (Postfix) with ESMTP id 1A34D37B479; Mon, 13 Nov 2000 21:34:29 -0800 (PST) Received: (from dave@localhost) by white.dogwood.com (8.11.1/8.9.3) id eAE5YOw05604; Mon, 13 Nov 2000 21:34:24 -0800 (PST) (envelope-from dave) From: Dave Cornejo Message-Id: <200011140534.eAE5YOw05604@white.dogwood.com> Subject: Re: cvs commit: src/sys/dev/an if_aironet_ieee.h if_an.c if_anreg.h src/usr.sbin/ancontrol ancontrol.8 ancontrol.cc In-Reply-To: <200011132304.PAA98092@freefall.freebsd.org> from Bill Paul at "Nov 13, 2000 03:04:16 pm" To: Bill Paul Date: Mon, 13 Nov 2000 21:34:24 -0800 (PST) Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL68 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I had corresponded with Doug right after I submitted the PR and we had agreed that my .h files were better and that his .c & ancontrol files were better. There is one glaring problem with the committed .h files and that is that the settings in the authtype field are wrong. You cannot actually set encryption properly with either the original or the committed files. There is, contrary to earlier Aironet documentation, no such bit as AN_AUTHTYPE_EXCLUDE_UNENCRYPTED. The correct AN_AUTHTYPES are as follows: #define AN_AUTHTYPE_NONE 0x0000 #define AN_AUTHTYPE_OPEN 0x0001 #define AN_AUTHTYPE_SHAREDKEY 0x0002 #define AN_AUTHTYPE_PRIVACY_IN_USE 0x0002 #define AN_AUTHTYPE_ALLOW_UNECNRYPTED 0x0002 (I'm pretty certain these are what I called them in my patch, but I'm doing this from memory) Full encryption is defined as AN_AUTHTYPE_{OPEN|SHARED} | AN_AUTHTYPE_PRIVACY_IN_USE Mixed cell is AN_AUTHTYPE_{OPEN|SHARED} | AN_AUTHTYPE_PRIVACY_IN_USE | AN_AUTHTYPE_ALLOW_UNENCRYPTED No encryption is AN_AUTHTYPE_NONE There are also some other things in my patch that fix errors in some of the structures (minor) and add support for some other interesting things in upcoming versions. [There is not really any good documentation out there on this right now or I'd cite it - I got this info direct from Aironet engineers] -- Dave Cornejo @ Dogwood Media, Fremont, California "There aren't any monkeys chasing us..." - Xochi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message