Date: Fri, 5 May 2000 15:30:59 +0100 (BST) From: Nick Hibma <n_hibma@calcaphon.com> To: Mike Nowlin <mike@argos.org> Cc: freebsd-current@freebsd.org, freebsd-gnats@freebsd.org, Tim Pozar <pozar@lns.com>, nsouch@freebsd.org Subject: Re: kern/16767 [PATCH] (A.K.A. Re: Geek Port crash) Message-ID: <Pine.BSF.4.20.0005051514580.10129-200000@localhost> In-Reply-To: <Pine.LNX.4.05.10005022317400.22957-100000@jason.argos.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-965986746-957537059=:10129 Content-Type: TEXT/PLAIN; charset=US-ASCII You seem to have put in some hard work there. Yes, your analysis is correct. the problem has been corrected not so long ago, albeit in a slightly different way. As it is now the ppi bus does not attach if the bus is polled mode. But you are saying it works in polled mode as well. I've attached a patch that only enables the alloc and setup of the irq in the case where PERIPH_1284 is defined. If that is defined, then the irq alloc is attempted, but if it fails, your patch kicks in and does not set it up in ppiopen. The patch is against current as of 2000-05-05, so you will have to update that part of the source. If this is not an option for you, let me know and send me the output of ident ppi.c, so I can make a patch for you. Mike, please let me know if this works for you. Nicolas, could you tell me whether this is the correct thing to do? the thing that I think is missing is somehow the possibility to use 'interrupts' even in polled mode. Basically the ppbus should simulate the interrupt by calling the interrupt after a poll has decided that an interrupt has occurred. Mike, well done! Nick -- n_hibma@webweaving.org n_hibma@freebsd.org USB project http://www.etla.net/~n_hibma/ --0-965986746-957537059=:10129 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ppi.c.diff" Content-Transfer-Encoding: BASE64 Content-ID: <Pine.BSF.4.20.0005051530590.10129@localhost> Content-Description: Content-Disposition: attachment; filename="ppi.c.diff" SW5kZXg6IHBwaS5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls ZTogL2hvbWUvbmN2cy9zcmMvc3lzL2Rldi9wcGJ1cy9wcGkuYyx2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMjINCmRpZmYgLXcgLXUgLXIxLjIyIHBwaS5j DQotLS0gcHBpLmMJMjAwMC8wNC8wNyAwMDowOToyNAkxLjIyDQorKysgcHBp LmMJMjAwMC8wNS8wNSAxNDoyNzoyNg0KQEAgLTY4LDggKzY4LDEwIEBADQog ICAgIGludAkJcHBpX21vZGU7CQkJLyogSUVFRTEyODQgbW9kZSAqLw0KICAg ICBjaGFyCXBwaV9idWZmZXJbQlVGU0laRV07DQogDQorI2lmZGVmIFBFUklQ SF8xMjg0DQogICAgIHN0cnVjdCByZXNvdXJjZSAqaW50cl9yZXNvdXJjZTsJ LyogaW50ZXJydXB0IHJlc291cmNlICovDQogICAgIHZvaWQgKmludHJfY29v a2llOwkJCS8qIGludGVycnVwdCByZWdpc3RyYXRpb24gY29va2llICovDQor I2VuZGlmIC8qIFBFUklQSF8xMjg0ICovDQogfTsNCiANCiAjZGVmaW5lIERF VlRPU09GVEMoZGV2KSBcDQpAQCAtMTcwLDEzICsxNzIsMTEgQEANCiAJLyog cmV0cml2ZSB0aGUgaXJxICovDQogCUJVU19SRUFEX0lWQVIoZGV2aWNlX2dl dF9wYXJlbnQoZGV2KSwgZGV2LCBQUEJVU19JVkFSX0lSUSwgJmlycSk7DQog DQorI2lmZGVmIFBFUklQSF8xMjg0DQogCS8qIGRlY2xhcmUgb3VyIGludGVy cnVwdCBoYW5kbGVyICovDQogCXBwaS0+aW50cl9yZXNvdXJjZSA9IGJ1c19h bGxvY19yZXNvdXJjZShkZXYsIFNZU19SRVNfSVJRLA0KIAkJCQkJCSZ6ZXJv LCBpcnEsIGlycSwgMSwgUkZfQUNUSVZFKTsNCi0JaWYgKHBwaS0+aW50cl9y ZXNvdXJjZSA9PSBOVUxMKSB7DQotCQlkZXZpY2VfcHJpbnRmKGRldiwgImNh bid0IGFsbG9jYXRlIGlycVxuIik7DQotCQlyZXR1cm4gKEVOT01FTSk7DQot CX0NCisjZW5kaWYgLyogUEVSSVBIXzEyODQgKi8NCiANCiAJbWFrZV9kZXYo JnBwaV9jZGV2c3csIGRldmljZV9nZXRfdW5pdChkZXYpLAkvKiBYWFggY2xl YW51cCAqLw0KIAkJIFVJRF9ST09ULCBHSURfV0hFRUwsDQpAQCAtMjc2LDkg KzI3NiwxMyBAQA0KIA0KIAkJcHBpLT5wcGlfZmxhZ3MgfD0gSEFWRV9QUEJV UzsNCiANCisjaWZkZWYgUEVSSVBIXzEyODQNCisJCWlmIChwcGktPmludHJf cmVzb3VyY2UpIHsNCiAJCS8qIHJlZ2lzdGVyIG91ciBpbnRlcnJ1cHQgaGFu ZGxlciAqLw0KIAkJQlVTX1NFVFVQX0lOVFIoZGV2aWNlX2dldF9wYXJlbnQo cHBpZGV2KSwgcHBpZGV2LCBwcGktPmludHJfcmVzb3VyY2UsDQogCQkJICAg ICAgIElOVFJfVFlQRV9UVFksIHBwaWludHIsIGRldiwgJnBwaS0+aW50cl9j b29raWUpOw0KKwkJfQ0KKyNlbmRpZiAvKiBQRVJJUEhfMTI4NCAqLw0KIAl9 DQogCXBwaS0+cHBpX2NvdW50ICs9IDE7DQogDQo= --0-965986746-957537059=:10129-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.20.0005051514580.10129-200000>