From owner-freebsd-current@FreeBSD.ORG Mon Apr 11 16:13:35 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A81C16A4ED; Mon, 11 Apr 2005 16:13:35 +0000 (GMT) Received: from postal1.es.net (postal1.es.net [198.128.3.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEC2043D2F; Mon, 11 Apr 2005 16:13:34 +0000 (GMT) (envelope-from oberman@es.net) Received: from ptavv.es.net ([198.128.4.29]) by postal1.es.net (Postal Node 1) with ESMTP (SSL) id IBA74465; Mon, 11 Apr 2005 09:13:34 -0700 Received: from ptavv (localhost [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 53EF45D08; Mon, 11 Apr 2005 09:13:34 -0700 (PDT) To: Wiktor Niesiobedzki In-reply-to: Your message of "Sun, 10 Apr 2005 13:12:02 +0200." <20050410111202.GA5980@dln55.neoplus.adsl.tpnet.pl> Date: Mon, 11 Apr 2005 09:13:34 -0700 From: "Kevin Oberman" Message-Id: <20050411161334.53EF45D08@ptavv.es.net> cc: current@freebsd.org cc: sos@freebsd.org Subject: Re: ATA MkIII - Hang after resume solution X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2005 16:13:35 -0000 > Date: Sun, 10 Apr 2005 13:12:02 +0200 > From: Wiktor Niesiobedzki > Sender: owner-freebsd-current@freebsd.org > > Hi, > > I think I found solution to the problem, that after MkIII disks does not > reinit. Solution is simple: > > --- /usr/src/sys/dev/ata/ata-pci.c Fri Apr 8 11:37:47 2005 > +++ /tmp/ata-pci.c Sun Apr 10 13:09:48 2005 > @@ -599,8 +599,8 @@ > DEVMETHOD(device_attach, ata_pcichannel_attach), > DEVMETHOD(device_detach, ata_pcichannel_detach), > DEVMETHOD(device_shutdown, bus_generic_shutdown), > - DEVMETHOD(device_suspend, bus_generic_suspend), > - DEVMETHOD(device_resume, bus_generic_resume), > + DEVMETHOD(device_suspend, ata_suspend), > + DEVMETHOD(device_resume, ata_resume), > > /* ATA methods */ > DEVMETHOD(ata_setmode, ata_pcichannel_setmode), > > This is rollback of changes introduced by MkIII. After that change > suspend/resume works again. > > Can anybody review this? Sorry, but I have been on the road and couldn't test until this morning. ata is now resuming again and I can can now successfully suspend and resume my ThinkPad T30. I have tried suspending and resuming both in console mode and in X. Everything appears to re running as it did prior to MkIII except the slight oddity that the cd (atapicam) now does not probe until after root is mounted. If I boot single user, the probe messages pop up after I am asked for the shell to be run. This does not seem to have any impact on things. It's just that I have never seen probes for devices present at boot show up after root is mounted. -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634