From owner-freebsd-current@FreeBSD.ORG Thu Feb 7 23:43:08 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 352D030D; Thu, 7 Feb 2013 23:43:08 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id CBAB57D0; Thu, 7 Feb 2013 23:43:07 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqAEAJA7FFGDaFvO/2dsb2JhbABFhkm6R3OCHwEBAQQBAQEgBCcgCxsOChEZAgQlAQkmBggHBAEcBIdwDK1dklCNJIMlgRMDiGaGLYRcgjKBHYg4hn2DHoFRNQ X-IronPort-AV: E=Sophos;i="4.84,625,1355115600"; d="scan'208";a="13004652" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu.net.uoguelph.ca with ESMTP; 07 Feb 2013 18:43:06 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id DF840B403A; Thu, 7 Feb 2013 18:43:06 -0500 (EST) Date: Thu, 7 Feb 2013 18:43:06 -0500 (EST) From: Rick Macklem To: Sergey Kandaurov Message-ID: <645868904.2814576.1360280586902.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <1644867646.2814542.1360280498907.JavaMail.root@erie.cs.uoguelph.ca> Subject: Re: panic: LK_RETRY set with incompatible flags MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2814575_1074866324.1360280586899" X-Originating-IP: [172.17.91.202] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - FF3.0 (Win)/6.0.10_GA_2692) Cc: Konstantin Belousov , FreeBSD Current , Andriy Gapon X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2013 23:43:08 -0000 ------=_Part_2814575_1074866324.1360280586899 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sergey Kandaurov wrote: > Sergey Kandaurov wrote: > > On 7 February 2013 19:42, Andriy Gapon wrote: > > > on 07/02/2013 17:36 Sergey Kandaurov said the following: > > >> I tested the patch without the (*vpp != dvp) change. > > >> It works well. > > >> > > >> It's something unrelated but when doing ls -l > > >> on server (patched) and client (unpatched) sides, > > >> I found some inconsistency in returned stats. > > >> Or more precisely: > > >> > > >> NFS server > > >> # stat -s /pool1/user1000/.zfs/shares/.. > > >> st_dev=2050684725 st_ino=1 st_mode=040555 st_nlink=4 st_uid=0 > > >> st_gid=0 > > >> st_rdev=0 st_size=4 st_atime=1360251211 st_mtime=1359551493 > > >> st_ctime=1359551493 st_birthtime=1359551493 st_blksize=4096 > > >> st_blocks=0 st_flags=0 > > >> > > >> NFS client > > >> # stat -s /home/user1000/.zfs/shares/.. > > >> st_dev=2050684725 st_ino=7 st_mode=040555 st_nlink=2 st_uid=0 > > >> st_gid=0 > > >> st_rdev=1377468712 st_size=2 st_atime=1360251104 > > >> st_mtime=1359551493 > > >> st_ctime=1359551493 st_birthtime=-1 st_blksize=4096 st_blocks=3 > > >> st_flags=0 > > > > > > Hmm, this looks more consistent with the earlier patch. > > > Are you sure that you really tested the new kernel (on the > > > server)? > > > > Sorry, I indeed booted a wrong kernel. > > Now tested the really new kernel :) And it works as well. > > stat -s looks consistent, thanks. > > > > # stat -s /home/user1000/.zfs/shares/.. > > st_dev=2050684725 st_ino=1 st_mode=040555 st_nlink=4 st_uid=0 > > st_gid=0 > > st_rdev=0 st_size=4 st_atime=1360252962 st_mtime=1359551493 > > st_ctime=1359551493 st_birthtime=-1 st_blksize=4096 st_blocks=0 > > st_flags=0 > > > Sounds good. I've attached a slightly updated patch with Andriy's > suggested addition of a check for zfsvfs->z_shares_dir != 0. > > I can't do any commits until April, so if one of you guys is > comfortable > enough with the patch to commit it, you are more than welcome to do > so. > > Thanks everyone for your help in resolving this, rick > I did my usual brain fart and forgot to attach the updated patch. Here it is..rick > > -- > > wbr, > > pluknet > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to > > "freebsd-current-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" ------=_Part_2814575_1074866324.1360280586899 Content-Type: text/x-patch; name=zfs-shares.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=zfs-shares.patch LS0tIGNkZGwvY29udHJpYi9vcGVuc29sYXJpcy91dHMvY29tbW9uL2ZzL3pmcy96ZnNfdmZzb3Bz LmMuc2F2CTIwMTMtMDItMDYgMTk6Mzg6NDEuMDAwMDAwMDAwIC0wNTAwCisrKyBjZGRsL2NvbnRy aWIvb3BlbnNvbGFyaXMvdXRzL2NvbW1vbi9mcy96ZnMvemZzX3Zmc29wcy5jCTIwMTMtMDItMDcg MTA6MjU6MDQuMDAwMDAwMDAwIC0wNTAwCkBAIC0yMDA5LDcgKzIwMDksOCBAQCB6ZnNfdmdldCh2 ZnNfdCAqdmZzcCwgaW5vX3QgaW5vLCBpbnQgZmxhCiAJICogLnpmcy9zbmFwc2hvdC8gZGlyZWN0 b3JpZXMsIHRoYXQncyB3aHkgd2UgcmV0dXJuIEVPUE5PVFNVUFAuCiAJICogVGhpcyB3aWxsIG1h a2UgTkZTIHRvIHN3aXRjaCB0byBMT09LVVAgaW5zdGVhZCBvZiB1c2luZyBWR0VULgogCSAqLwot CWlmIChpbm8gPT0gWkZTQ1RMX0lOT19ST09UIHx8IGlubyA9PSBaRlNDVExfSU5PX1NOQVBESVIp CisJaWYgKGlubyA9PSBaRlNDVExfSU5PX1JPT1QgfHwgaW5vID09IFpGU0NUTF9JTk9fU05BUERJ UiB8fAorCSAgICAoemZzdmZzLT56X3NoYXJlc19kaXIgIT0gMCAmJiBpbm8gPT0gemZzdmZzLT56 X3NoYXJlc19kaXIpKQogCQlyZXR1cm4gKEVPUE5PVFNVUFApOwogCiAJWkZTX0VOVEVSKHpmc3Zm cyk7CkBAIC0yMDk5LDE0ICsyMTAwLDIyIEBAIHpmc19maHRvdnAodmZzX3QgKnZmc3AsIGZpZF90 ICpmaWRwLCBpbnQKIAkJcmV0dXJuIChFSU5WQUwpOwogCX0KIAotCS8qIEEgemVybyBmaWRfZ2Vu IG1lYW5zIHdlIGFyZSBpbiB0aGUgLnpmcyBjb250cm9sIGRpcmVjdG9yaWVzICovCi0JaWYgKGZp ZF9nZW4gPT0gMCAmJgotCSAgICAob2JqZWN0ID09IFpGU0NUTF9JTk9fUk9PVCB8fCBvYmplY3Qg PT0gWkZTQ1RMX0lOT19TTkFQRElSKSkgeworCS8qCisJICogQSB6ZXJvIGZpZF9nZW4gbWVhbnMg d2UgYXJlIGluIC56ZnMgb3IgdGhlIC56ZnMvc25hcHNob3QKKwkgKiBkaXJlY3RvcnkgdHJlZS4g SWYgdGhlIG9iamVjdCA9PSB6ZnN2ZnMtPnpfc2hhcmVzX2RpciwgdGhlbgorCSAqIHdlIGFyZSBp biB0aGUgLnpmcy9zaGFyZXMgZGlyZWN0b3J5IHRyZWUuCisJICovCisJaWYgKChmaWRfZ2VuID09 IDAgJiYKKwkgICAgIChvYmplY3QgPT0gWkZTQ1RMX0lOT19ST09UIHx8IG9iamVjdCA9PSBaRlND VExfSU5PX1NOQVBESVIpKSB8fAorCSAgICAoemZzdmZzLT56X3NoYXJlc19kaXIgIT0gMCAmJiBv YmplY3QgPT0gemZzdmZzLT56X3NoYXJlc19kaXIpKSB7CiAJCSp2cHAgPSB6ZnN2ZnMtPnpfY3Rs ZGlyOwogCQlBU1NFUlQoKnZwcCAhPSBOVUxMKTsKIAkJaWYgKG9iamVjdCA9PSBaRlNDVExfSU5P X1NOQVBESVIpIHsKIAkJCVZFUklGWSh6ZnNjdGxfcm9vdF9sb29rdXAoKnZwcCwgInNuYXBzaG90 IiwgdnBwLCBOVUxMLAogCQkJICAgIDAsIE5VTEwsIE5VTEwsIE5VTEwsIE5VTEwsIE5VTEwpID09 IDApOworCQl9IGVsc2UgaWYgKG9iamVjdCA9PSB6ZnN2ZnMtPnpfc2hhcmVzX2RpcikgeworCQkJ VkVSSUZZKHpmc2N0bF9yb290X2xvb2t1cCgqdnBwLCAic2hhcmVzIiwgdnBwLCBOVUxMLAorCQkJ ICAgIDAsIE5VTEwsIE5VTEwsIE5VTEwsIE5VTEwsIE5VTEwpID09IDApOwogCQl9IGVsc2Ugewog CQkJVk5fSE9MRCgqdnBwKTsKIAkJfQo= ------=_Part_2814575_1074866324.1360280586899--