From owner-svn-src-vendor@freebsd.org Tue Sep 3 14:06:09 2019 Return-Path: Delivered-To: svn-src-vendor@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CFD89DC47A; Tue, 3 Sep 2019 14:06:09 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7z52mbbz4PFr; Tue, 3 Sep 2019 14:06:09 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 103F31A21B; Tue, 3 Sep 2019 14:05:59 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 3B075A94E; Thu, 4 Apr 2019 04:10:06 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CF2C8349F; Thu, 4 Apr 2019 04:10:05 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 214CDA8ED; Thu, 4 Apr 2019 04:10:05 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id B41F5A8EA; Thu, 4 Apr 2019 04:10:02 +0000 (UTC) (envelope-from phil@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C17F8349A; Thu, 4 Apr 2019 04:10:02 +0000 (UTC) (envelope-from phil@juniper.net) Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3449AJ8032193; Wed, 3 Apr 2019 21:10:00 -0700 Received: from nam05-dm3-obe.outbound.protection.outlook.com (mail-dm3nam05lp2058.outbound.protection.outlook.com [104.47.49.58]) by mx0b-00273201.pphosted.com with ESMTP id 2rn2vw0nrf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 03 Apr 2019 21:10:00 -0700 Received: from BYAPR05CA0034.namprd05.prod.outlook.com (2603:10b6:a03:c0::47) by BN7PR05MB4178.namprd05.prod.outlook.com (2603:10b6:406:90::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.15; Thu, 4 Apr 2019 04:09:56 +0000 Received: from CO1NAM05FT039.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::203) by BYAPR05CA0034.outlook.office365.com (2603:10b6:a03:c0::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1771.7 via Frontend Transport; Thu, 4 Apr 2019 04:09:55 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from P-EXFEND-EQX-01.jnpr.net (66.129.239.12) by CO1NAM05FT039.mail.protection.outlook.com (10.152.96.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1771.6 via Frontend Transport; Thu, 4 Apr 2019 04:09:53 +0000 Received: from P-EXBEND-EQX-01.jnpr.net (10.104.8.52) by P-EXFEND-EQX-01.jnpr.net (10.104.8.54) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 3 Apr 2019 21:09:52 -0700 Received: from P-EXBEND-EQX-02.jnpr.net (10.104.8.53) by P-EXBEND-EQX-01.jnpr.net (10.104.8.52) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 3 Apr 2019 21:09:51 -0700 Received: from p-mailhub01.juniper.net (10.104.20.6) by P-EXBEND-EQX-02.jnpr.net (10.104.8.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 3 Apr 2019 21:09:51 -0700 Received: from idle.juniper.net (idleski.juniper.net [172.25.5.10]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id x3449npW013564; Wed, 3 Apr 2019 21:09:51 -0700 (envelope-from phil@juniper.net) Received: from [10.0.0.3] (localhost [127.0.0.1]) by idle.juniper.net (8.15.2/8.15.2) with ESMTP id x344AcgY069097; Thu, 4 Apr 2019 00:10:38 -0400 (EDT) (envelope-from phil@juniper.net) From: Phil Shafer To: Enji Cooper CC: Phil Shafer , src-committers , svn-src-all , Subject: Re: svn commit: r345860 - vendor/Juniper/libxo X-Mailer: MailMate (1.12.4r5608) Message-ID: <2C38A6BB-9915-4BC1-88BD-EA6919FFFED5@juniper.net> In-Reply-To: References: <201904032230.x33MUKRn029430@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e3cb0ff2-54e7-4646-8a04-0dae4ac7b136 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(396003)(39860400002)(346002)(136003)(376002)(2980300002)(199004)(189003)(26005)(77096007)(186003)(316002)(7126003)(33656002)(76506005)(476003)(426003)(336012)(6916009)(2616005)(106466001)(105596002)(82746002)(68736007)(11346002)(53936002)(69596002)(229853002)(6246003)(2906002)(67846002)(54906003)(446003)(305945005)(97736004)(4326008)(486006)(50466002)(126002)(5660300002)(23676004)(478600001)(47776003)(1411001)(36756003)(2870700001)(76176011)(8676002)(356004)(6666004)(53546011)(50226002)(86362001)(83716004)(8936002)(2486003)(81156014)(81166006); DIR:OUT; SFP:1102; SCL:1; SRVR:BN7PR05MB4178; H:P-EXFEND-EQX-01.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 532c5ecb-8af0-41d2-c3b9-08d6b8b364c5 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4710095)(4711036)(2017052603328); SRVR:BN7PR05MB4178; X-MS-TrafficTypeDiagnostic: BN7PR05MB4178: X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0997523C40 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: wX0bvfzsGm3vBFqpmMlKu5Kmc706uk5KYF66XkNvDYloOLiIz9nRc+oOBhMwxQ93bA+MPG2Zz8O0z2I6nQZKprnJZS8VecIHIvLKZ4drtryBa85y1DCwksmYpI7DvMbaZLqb+DlcRIu0rs0EWn03avE6eXWnBtWRPgtOrPYZxMQCcgiGvjUMnQ23RVtQZYFGIgM3BoU0cRKdvfEu85Xqs88a5J7MViAZjGPehXKN33Qsjnr+FJzwppBzlJqreHffUI7GJFVsjGFOlCgD/ZSXCsdLc2jb2Bz68xWmcKhA3YifFe72DrnzF7BBQbl4QebY8eHu1ENPp5lGOAcTzY33xvkoZeON6SRSxYqIzunRIfSt7Xcm4wPEJPBhKv/4dOcllaW0rLPANqhgyMTiAZJ7TiVMlvfNbM7Il8Q+gOkGxUU= X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2019 04:09:53.0457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 532c5ecb-8af0-41d2-c3b9-08d6b8b364c5 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[P-EXFEND-EQX-01.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR05MB4178 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-04_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904040028 Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 4CF2C8349F X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.966,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:10 -0000 X-Original-Date: Thu, 4 Apr 2019 00:09:48 -0400 X-List-Received-Date: Tue, 03 Sep 2019 14:06:10 -0000 On 3 Apr 2019, at 23:07, Enji Cooper wrote: > I could be wrong, but I’m guessing `GMAKE` needs to be replaced with > `MAKE`..? GMAKE is set inside the import script, where MAKE=gmake is for configure. > Also, why does a configure script need gmake? It seems like the > snippets that make libxo should be made more portable with autoconf, > if that’s the case. configure uses gmake to build dependencies, but assumes "make" means gmake (${MAKE-make}). When it finds real make instead it will complain: Something went wrong bootstrapping makefile fragments for automatic dependency tracking. Try re-running configure with the '--disable-dependency-tracking' option to at least be able to build the package (albeit without support for automatic dependency tracking). See `config.log' for more details The autoconf tools are increasingly linux-centric, so the MAKE=gmake is needed for BSD platforms. Longer term, I will probably move away from them, as more problems are appearing. For example, libtool is not naming test executables "lt-text_01.test", which makes the output of "make test" different under linux (since error messages include argv[0]. So now I need to call xo_program() to explicitly set the name. Eventually cost(work-arounds) > cost(requiring-bmake). Thanks, Phil