From owner-freebsd-net@freebsd.org Sat Jan 14 10:44:35 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE678CA7BAD for ; Sat, 14 Jan 2017 10:44:35 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: from mail-ot0-x232.google.com (mail-ot0-x232.google.com [IPv6:2607:f8b0:4003:c0f::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8245A1ED2 for ; Sat, 14 Jan 2017 10:44:35 +0000 (UTC) (envelope-from v.maffione@gmail.com) Received: by mail-ot0-x232.google.com with SMTP id 104so17255542otd.3 for ; Sat, 14 Jan 2017 02:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iiGF5v84NYO7bfihe5lKD3KgxcpAe/cVDxz7dY26HIg=; b=j2atgVmpZmEIb7bFsEHO8D3ecPGSQh44r1GIRR3dmrMfVpt/CoApua2fgvTjuJLSQf Uay9+Xa3wZyDL1WooUvuYizBW5iT8HC3JGh++4Q9S7m/9znxct8C0r447CwcKHIaspfr iG3Y+9u51W5VbBP2ycopLxh1UzGtdPMy5EWwK8Xz6GAOM1xANhcTC/dmn3ANRVBomRes OEii4TCxtyfgypic15QUJteNn0B1bEH/rkvP3OT3AiYTVkr3amZsW5HghvE6cxrj4CLe zJmFydaFaBNgRSU4o86aOlchBwM8SNsUak6jY2Ud/5y4k2uv+2gh27scNaI+PDDAwu4U nbag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iiGF5v84NYO7bfihe5lKD3KgxcpAe/cVDxz7dY26HIg=; b=hTPcs+uu0q2cLIL+GmL/yKOh6+0AGut3G2KxoAEfbWyrVxTdYyra/AXi2cirfdoXCZ wZfjs0SJwKlPbBKqFukWtQgAs2TZ4DNe15J0ADD6bVvadBbNyNdwsbmhf5PUSb9vZcia gGg0HZdmM+MQjv96QjEw7YTL9tguK0ZoAIA9CaXnwWgv/QD9Ro5Ievulv3hdPoHiFhqa hrDnEpd2txRIq1/Fb9qiSkt6rI8ksgJIM6EF9X9B8Z5QoF6gWDirwKT6Pa82d9YywIJ5 v1ctm2CCNpAUEPHWAr6mL1WuGojmSA+2PuUJKxtxcMph3HJosNuLjl0myHL5ov7rEMaK CY6w== X-Gm-Message-State: AIkVDXLVg+GhTGdJQdwxM8jNJ1cW/Ld70u5cBdbIce6wZUGlI7PkrojsUQ+jNU2bVYTf/9MG3byCpk5QD6v6Yw== X-Received: by 10.157.60.238 with SMTP id t43mr12472662otf.178.1484390674834; Sat, 14 Jan 2017 02:44:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.6.166 with HTTP; Sat, 14 Jan 2017 02:44:34 -0800 (PST) In-Reply-To: <49F36EE5-D3BD-420A-9F16-2219C7C83AC8@gmail.com> References: <49F36EE5-D3BD-420A-9F16-2219C7C83AC8@gmail.com> From: Vincenzo Maffione Date: Sat, 14 Jan 2017 11:44:34 +0100 Message-ID: Subject: Re: powerpc.LINT* broken in netmap(4) To: FreeBSD Net Cc: Luigi Rizzo , "Ngie Cooper (yaneurabeya)" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2017 10:44:35 -0000 2017-01-13 23:27 GMT+01:00 Ngie Cooper (yaneurabeya) : > > > On Jan 13, 2017, at 02:22, Ngie Cooper (yaneurabeya) < > yaneurabeya@gmail.com> wrote: > > > > Hi, > > I spotted these compilation errors on universe12a.freebsd.org for > both powerpc.LINT and powerpc.LINT64: > > > > cc1: warnings being treated as errors > > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c: In function > 'generic_set_tx_event': > > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c:765: warning: the > address of 'generic_mbuf_destructor' will always evaluate as 'true' > [-Waddress] > > --- netmap_generic.o --- > > *** [netmap_generic.o] Error code 1 > > > > I haven=E2=80=99t yet dug into why this only surfaces on powerpc,= yet=E2=80=A6 > > (CC -powerpc; BCC +powerpc) > Hi, > sparc64 has the same issue as powerpc*, so I suspect that gcc is > flagging this as an issue. > Thanks, > -Ngie > > PS. Sidenote: why was the SET_MBUF_DESTRUCTOR macro added, but not used i= n > nm_os_get_mbuf ? > Because the destructor is set only on certain mbufs, selected to issue notifications to netmap applications. The proper fix is probably to turn the macro to a function, I cannot think of other solutions. Cheers, Vincenzo --=20 Vincenzo Maffione