From owner-p4-projects@FreeBSD.ORG Sun Nov 11 23:08:38 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6F5F716A46B; Sun, 11 Nov 2007 23:08:38 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 192B116A417 for ; Sun, 11 Nov 2007 23:08:37 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id E07AB13C49D for ; Sun, 11 Nov 2007 23:08:36 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lABN8aGo090973 for ; Sun, 11 Nov 2007 23:08:36 GMT (envelope-from jb@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lABN8a1m090970 for perforce@freebsd.org; Sun, 11 Nov 2007 23:08:36 GMT (envelope-from jb@freebsd.org) Date: Sun, 11 Nov 2007 23:08:36 GMT Message-Id: <200711112308.lABN8a1m090970@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jb@freebsd.org using -f From: John Birrell To: Perforce Change Reviews Cc: Subject: PERFORCE change 128952 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2007 23:08:38 -0000 http://perforce.freebsd.org/chv.cgi?CH=128952 Change 128952 by jb@jb_freebsd1 on 2007/11/11 23:08:13 This file contains badness. Yuk. We really need to go back to using -Werror (which is how I caught this). Affected files ... .. //depot/projects/dtrace/src/usr.bin/fstat/zfs/zfs.c#2 edit Differences ... ==== //depot/projects/dtrace/src/usr.bin/fstat/zfs/zfs.c#2 (text+ko) ==== @@ -68,7 +68,8 @@ uint64_t *zid; void *znodeptr, *vnodeptr; char *dataptr; - int len, size, *zphys_addr; + int *zphys_addr; + size_t len, size; len = sizeof(size); if (sysctlbyname("debug.sizeof.znode", &size, &len, NULL, 0) == -1) {