Date: Mon, 19 Jun 1995 16:50:00 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: gpalmer@freefall.cdrom.com (Gary Palmer) Cc: CVS-commiters@freefall.cdrom.com, cvs-user@freefall.cdrom.com Subject: Re: cvs commit: src/release/sysinstall tcpip.c Message-ID: <199506192350.QAA02166@gndrsh.aac.dev.com> In-Reply-To: <199506192329.QAA19505@freefall.cdrom.com> from "Gary Palmer" at Jun 19, 95 04:29:52 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > gpalmer 95/06/19 16:29:51 > > Modified: release/sysinstall tcpip.c > Log: > Fix bogon in network address checking code. It nows allows the number > 255 in the first three fields, although 255 in the last octet is still > considered an error, as it is still a broadcast address (AFAIK). You can not know what is the boardcast address without using the netmask, if you are trying to check for bogus input values either make sure it is done correctly and completly or don't do it at all and allow the user to shoot himself in the foot. I think I would rather just see the check die than to have errors in it like this. Your assumption above is that the person is on a non-subnetted class C network or on a subnetted class B split 256/256 or a subnetted class A slit 65536/256. Pretty darn large assumption considering many of our users are more than likely on a subnetted class C for there slip/ppp link with a netmask of 252 and the broadcast address being just the low 2 bits set to 1's. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199506192350.QAA02166>