Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Feb 2015 01:17:46 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r279195 - stable/10/sys/dev/acpica
Message-ID:  <201502230117.t1N1HkbR078512@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Mon Feb 23 01:17:45 2015
New Revision: 279195
URL: https://svnweb.freebsd.org/changeset/base/279195

Log:
  MFC r278871:
  Array cannot be NULL, remove always true comparision.

Modified:
  stable/10/sys/dev/acpica/acpi_pcib.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/acpica/acpi_pcib.c
==============================================================================
--- stable/10/sys/dev/acpica/acpi_pcib.c	Sun Feb 22 22:53:51 2015	(r279194)
+++ stable/10/sys/dev/acpica/acpi_pcib.c	Mon Feb 23 01:17:45 2015	(r279195)
@@ -95,7 +95,7 @@ prt_attach_devices(ACPI_PCI_ROUTING_TABL
     int error;
 
     /* We only care about entries that reference a link device. */
-    if (entry->Source == NULL || entry->Source[0] == '\0')
+    if (entry->Source[0] == '\0')
 	return;
 
     /*
@@ -222,7 +222,7 @@ acpi_pcib_route_interrupt(device_t pcib,
     if (bootverbose) {
 	device_printf(pcib, "matched entry for %d.%d.INT%c",
 	    pci_get_bus(dev), pci_get_slot(dev), 'A' + pin);
-	if (prt->Source != NULL && prt->Source[0] != '\0')
+	if (prt->Source[0] != '\0')
 		printf(" (src %s:%u)", prt->Source, prt->SourceIndex);
 	printf("\n");
     }
@@ -234,8 +234,7 @@ acpi_pcib_route_interrupt(device_t pcib,
      * XXX: If the source index is non-zero, ignore the source device and
      * assume that this is a hard-wired entry.
      */
-    if (prt->Source == NULL || prt->Source[0] == '\0' ||
-	prt->SourceIndex != 0) {
+    if (prt->Source[0] == '\0' || prt->SourceIndex != 0) {
 	if (bootverbose)
 	    device_printf(pcib, "slot %d INT%c hardwired to IRQ %d\n",
 		pci_get_slot(dev), 'A' + pin, prt->SourceIndex);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201502230117.t1N1HkbR078512>