From owner-cvs-all@FreeBSD.ORG Tue Nov 20 13:24:56 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3032916A419; Tue, 20 Nov 2007 13:24:56 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id E706513C459; Tue, 20 Nov 2007 13:24:55 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 3F22A2089; Tue, 20 Nov 2007 14:24:47 +0100 (CET) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.1/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id B153E2085; Tue, 20 Nov 2007 14:24:46 +0100 (CET) Received: by ds4.des.no (Postfix, from userid 1001) id 9B8B284485; Tue, 20 Nov 2007 14:24:46 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: John Birrell References: <200711200207.lAK27UmF082244@repoman.freebsd.org> <20071120082329.C53707@maildrop.int.zabbadoz.net> <20071120093155.GA6959@what-creek.com> Date: Tue, 20 Nov 2007 14:24:46 +0100 In-Reply-To: <20071120093155.GA6959@what-creek.com> (John Birrell's message of "Tue\, 20 Nov 2007 09\:31\:55 +0000") Message-ID: <8663zxcan5.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: "Bjoern A. Zeeb" , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/lib/libkse Makefile src/lib/libthr Makefile src/usr.bin/netstat Makefile src/usr.sbin/acpi/acpidb Makefile src/usr.sbin/kldxref Makefile src/usr.sbin/nscd Makefile src/usr.sbin/rpc.yppasswdd Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2007 13:24:56 -0000 John Birrell writes: > The thing that I take issue with is holding off re-enabling the WARNS > -Werror checks which used to serve us well simply because there are > custom CFLAGS set on the tinderboxes which cause non-fatal errors > that nobody _ever_ _looks_ _at_. The errors are non-fatal because > -Werror was disabled. The errors are serious and should be fixed. They represent *actual bugs* or at the very least serious design issues in the code. Nobody benefits from sweeping them under the rug. The reason why nobody looks at them is *precisely* the fact that they don't stop the build. This is *precisely* why I disapprove of the use of -fno-strict-aliasing. > As an exercise to the readers of this message, please take a look > at src/lib/libthr, our preferred threading library. libthr has serious aliasing issues which I have commented on before. I will not discuss them further on a public list. > I would prefer that the tinderboxes run with the same defaults that > we have in CVS, however, from what I have seen today, I think that we > may need to rethink our defaults. I have said this repeatedly in the past. Perhaps someone will listen when it isn't me saying it? DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no