From owner-svn-src-all@FreeBSD.ORG Mon Mar 23 14:42:13 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A2CD2511; Mon, 23 Mar 2015 14:42:13 +0000 (UTC) Received: from borg.macktronics.com (borg.macktronics.com [209.181.253.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C8597D4; Mon, 23 Mar 2015 14:42:12 +0000 (UTC) Received: from olive.macktronics.com (olive.macktronics.com [209.181.253.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by borg.macktronics.com (Postfix) with ESMTPS id 59DE9546; Mon, 23 Mar 2015 09:35:55 -0500 (CDT) Date: Mon, 23 Mar 2015 09:35:54 -0500 (CDT) From: Dan Mack To: Alexander Motin Subject: Re: svn commit: r280363 - stable/10/usr.sbin/bhyve In-Reply-To: <201503231148.t2NBmQ7o024956@svn.freebsd.org> Message-ID: References: <201503231148.t2NBmQ7o024956@svn.freebsd.org> User-Agent: Alpine 2.20 (BSF 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 14:42:13 -0000 I just tried to build 280369 and got this: --- all_subdir_bhyve --- /usr/src/usr.sbin/bhyve/pci_ahci.c:1512:8: error: use of undeclared identifier 'dsm' ncq = dsm = 0; ^ 1 error generated. *** [pci_ahci.o] Error code 1 This is on 10.1-Stable Dan On Mon, 23 Mar 2015, Alexander Motin wrote: > Author: mav > Date: Mon Mar 23 11:48:25 2015 > New Revision: 280363 > URL: https://svnweb.freebsd.org/changeset/base/280363 > > Log: > MFC r280293: Add missing variable initialization. > > Reported by: Coverity > CID: 1288938 > > Modified: > stable/10/usr.sbin/bhyve/pci_ahci.c > Directory Properties: > stable/10/ (props changed) > > Modified: stable/10/usr.sbin/bhyve/pci_ahci.c > ============================================================================== > --- stable/10/usr.sbin/bhyve/pci_ahci.c Mon Mar 23 11:47:01 2015 (r280362) > +++ stable/10/usr.sbin/bhyve/pci_ahci.c Mon Mar 23 11:48:25 2015 (r280363) > @@ -1509,7 +1509,7 @@ ata_ioreq_cb(struct blockif_req *br, int > > DPRINTF("%s %d\n", __func__, err); > > - ncq = 0; > + ncq = dsm = 0; > aior = br->br_param; > p = aior->io_pr; > cfis = aior->cfis; > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > dan -- Dan Mack